Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: only defer _final call when connecting #47385

Merged
merged 1 commit into from
May 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ Socket.prototype._unrefTimer = function _unrefTimer() {
// sent out to the other side.
Socket.prototype._final = function(cb) {
// If still connecting - defer handling `_final` until 'connect' will happen
if (this.pending) {
if (this.connecting) {
debug('_final: not yet connected');
return this.once('connect', () => this._final(cb));
}
Expand Down
7 changes: 5 additions & 2 deletions test/parallel/test-net-end-without-connect.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');
const common = require('../common');
const net = require('net');
const assert = require('assert');

const sock = new net.Socket();
sock.end(); // Should not throw.
sock.end(common.mustCall(() => {
assert.strictEqual(sock.writable, false);
}));