Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove Python pip --no-user option (#47338) #47372

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 2, 2023

Python pip no longer has a --no-user option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 2, 2023
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott
Copy link
Member Author

Trott commented Apr 2, 2023

This is a re-landing for #47338.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2023
@nodejs-github-bot
Copy link
Collaborator

@debadree25
Copy link
Member

would the commit title need to be renamed? it still has the PR url

@Trott
Copy link
Member Author

Trott commented Apr 2, 2023

would the commit title need to be renamed? it still has the PR url

Oh, yeah, I should remove that. I'll force push and restart CI. Thanks.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: nodejs#47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@aduh95
Copy link
Contributor

aduh95 commented Apr 2, 2023

Landed in cce5a8c

@aduh95 aduh95 merged commit cce5a8c into nodejs:main Apr 2, 2023
@Trott Trott deleted the reland-47338 branch April 2, 2023 21:28
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: nodejs#47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants