Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] WebCryptoAPI fixes #47336

Closed
wants to merge 13 commits into from
Closed

[v16.x backport] WebCryptoAPI fixes #47336

wants to merge 13 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Mar 31, 2023 •
edited
Loading

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v16.x labels Mar 31, 2023
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
@panva
crypto: add CryptoKey Symbol.toStringTag
3c51e4f 
closes nodejs#45987

PR-URL: nodejs#46042
Fixes: nodejs#45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Backport-PR-URL: nodejs#47336
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
@panva
crypto: add KeyObject Symbol.toStringTag
c915898 
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@panva panva force-pushed the backport-crypto-symbols-to-v16.x branch from 6a2ac47 to c915898 Compare March 31, 2023 11:18
@panva panva marked this pull request as ready for review March 31, 2023 11:18
@panva panva changed the title [v16.x] backport CryptoKey and KeyObject prototype SymbolToStringTag [v16.x backport] CryptoKey and KeyObject prototype SymbolToStringTag Mar 31, 2023
@panva
crypto: add CryptoKey Symbol.toStringTag
bc17568 
closes nodejs#45987

PR-URL: nodejs#46042
Fixes: nodejs#45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Backport-PR-URL: nodejs#47336
@panva
crypto: add KeyObject Symbol.toStringTag
cca5940 
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@panva panva force-pushed the backport-crypto-symbols-to-v16.x branch from c915898 to cca5940 Compare March 31, 2023 11:24
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 31, 2023
@panva panva marked this pull request as draft March 31, 2023 11:39
@panva
crypto: handle more webcrypto errors with OperationError
c7c5011 
PR-URL: nodejs#45320
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@panva
test: mock structuredClone for WebCryptoAPI WPTs
5b9738a
@panva
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
ae600b9 
PR-URL: nodejs#44917
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Backport-PR-URL: nodejs#47336
@panva
crypto: ensure "x" is present when importing private CFRG webcrypto keys
252839a 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@panva
crypto: fix X25519 and X448 webcrypto public CryptoKey usages
a321238 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@panva panva added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. experimental Issues and PRs related to experimental features. labels Mar 31, 2023
@panva panva marked this pull request as ready for review March 31, 2023 12:18
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
@panva
crypto: use DataError for webcrypto keyData import failures
c62ed73 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
@panva
crypto: validate CFRG webcrypto JWK import "d" and "x" are a pair
cf1e907 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
@panva
crypto: fix ECDH webcrypto public CryptoKey usages
357855f 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@panva panva changed the title [v16.x backport] CryptoKey and KeyObject prototype SymbolToStringTag [v16.x] backport WebCryptoAPI fixes Mar 31, 2023
@panva
crypto: use DataError for webcrypto keyData import failures
b72552c 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@panva
crypto: validate CFRG webcrypto JWK import "d" and "x" are a pair
adca91a 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@panva
crypto: fix ECDH webcrypto public CryptoKey usages
8570ffa 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50796/

@github-actions github-actions bot mentioned this pull request Apr 2, 2023
Open
30 tasks
@panva
Copy link
Member Author

panva commented Apr 2, 2023

cc @nodejs/backporters

@danielleadams
Copy link
Contributor

@panva I'm preparing v16.x for 4/4 - looks like this still needs reviewers before it can be landed.

@panva panva requested review from jasnell and tniessen April 2, 2023 21:06
@panva
Copy link
Member Author

panva commented Apr 2, 2023

@danielleadams there was 16.x minor release 4 days ago... There's another one planned for tuesday 4/4?

@github-actions github-actions bot mentioned this pull request Apr 3, 2023
Open
28 tasks
@panva
Copy link
Member Author

panva commented Apr 3, 2023

cc @nodejs/crypto

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Apr 9, 2023
@panva panva removed the review wanted PRs that need reviews. label Apr 26, 2023
panva added 3 commits May 15, 2023 21:02
@panva
crypto: use WebIDL converters in WebCryptoAPI
d50a7dc 
WebCryptoAPI functions' arguments are now coersed and validated as per
their WebIDL definitions like in other Web Crypto API implementations.
This further improves interoperability with other implementations of
Web Crypto API.

PR-URL: nodejs#46067
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Backport-PR-URL: nodejs#47336
@panva
crypto: re-add padding for AES-KW wrapped JWKs
588a166 
PR-URL: nodejs#46563
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: nodejs#47336
@panva
crypto: fix webcrypto private/secret import with empty usages
ca5b942 
Refs: nodejs#47864
PR-URL: nodejs#47877
Refs: nodejs#47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: nodejs#47336
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51820/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51823/

This was referenced May 16, 2023
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request May 23, 2023
Open
22 tasks
@panva
Copy link
Member Author

panva commented Jul 26, 2023

This is no longer likely to make an impact on v16.x LTS with its EOL in ~6 week

@panva panva closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@tniessen tniessen tniessen approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @danielleadams @tniessen