Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add servername parameter docs #4729

Closed
wants to merge 1 commit into from
Closed

doc: add servername parameter docs #4729

wants to merge 1 commit into from

Conversation

estliberitas
Copy link
Contributor

Add servername parameter docs for https.request() method.

Follows #4389

@estliberitas
doc: add servername parameter docs
ae79eaa 
Add `servername` parameter docs for `https.request()` method.

Follows #4389
@mscdex mscdex added https Issues or PRs related to the https subsystem. doc Issues and PRs related to the documentations. labels Jan 17, 2016
@jasnell
Copy link
Member

jasnell commented Jan 18, 2016

LGTM

@silverwind
Copy link
Contributor

cc: @indutny

@indutny
Copy link
Member

indutny commented Jan 25, 2016

Do we have an existing test for this?

@estliberitas
Copy link
Contributor Author

@indutny You did in #4389 I guess

@indutny
Copy link
Member

indutny commented Jan 25, 2016

True, LGTM. Thank you!

silverwind pushed a commit that referenced this pull request Jan 25, 2016
@estliberitas @silverwind
doc: add servername parameter docs
8ba5631 
Add `servername` parameter docs for `https.request()` method.

Follows #4389

PR-URL: #4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Thanks! Landed in 8ba5631.

@silverwind silverwind closed this Jan 25, 2016
rvagg pushed a commit that referenced this pull request Jan 26, 2016
@estliberitas @rvagg
doc: add servername parameter docs
a1af6fc 
Add `servername` parameter docs for `https.request()` method.

Follows #4389

PR-URL: #4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
@estliberitas @benjamingr
doc: add servername parameter docs
d3ce9d3 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
@estliberitas
doc: add servername parameter docs
d479686 
Add `servername` parameter docs for `https.request()` method.

Follows #4389

PR-URL: #4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
@estliberitas
doc: add servername parameter docs
1282663 
Add `servername` parameter docs for `https.request()` method.

Follows #4389

PR-URL: #4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
@estliberitas
doc: add servername parameter docs
096a31e 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 13, 2016
@estliberitas @MylesBorins
doc: add servername parameter docs
c5ac66a 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@estliberitas estliberitas deleted the doc-https-fix-for-4389 branch February 14, 2016 17:04
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
@estliberitas
doc: add servername parameter docs
cb5986d 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@estliberitas
doc: add servername parameter docs
9be9463 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@estliberitas @jasnell @silverwind @indutny @mscdex @MylesBorins