-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in SECURITY.md #47282
Merged
Merged
doc: fix typo in SECURITY.md #47282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Mar 28, 2023
Fast-track has been requested by @Trott. Please 👍 to approve. |
tniessen
approved these changes
Mar 28, 2023
mhdawson
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lpinca
approved these changes
Mar 28, 2023
debadree25
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 28, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Mar 28, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47282 ✔ Done loading data for nodejs/node/pull/47282 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in SECURITY.md (#47282) Author Rich Trott (@Trott) Branch Trott:Trott-patch-1 -> nodejs:main Labels doc, fast-track Commits 1 - doc: fix typo in SECURITY.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/47282 Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47282 Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 28 Mar 2023 13:31:38 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361095224 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361352729 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361397071 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361471612 ℹ This PR is being fast-tracked ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4546278083 |
Trott
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Mar 28, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Mar 28, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47282 ✔ Done loading data for nodejs/node/pull/47282 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in SECURITY.md (#47282) Author Rich Trott (@Trott) Branch Trott:Trott-patch-1 -> nodejs:main Labels doc, fast-track Commits 1 - doc: fix typo in SECURITY.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/47282 Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47282 Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 28 Mar 2023 13:31:38 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361095224 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361352729 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361397071 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361471612 ℹ This PR is being fast-tracked ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4546948764 |
PR-URL: #47282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in da2210e |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
PR-URL: #47282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.