Skip to content

doc: fix typo in SECURITY.md#47282

Merged
Trott merged 1 commit intomainfrom
Trott-patch-1
Mar 28, 2023
Merged

doc: fix typo in SECURITY.md#47282
Trott merged 1 commit intomainfrom
Trott-patch-1

Conversation

@Trott
Copy link
Member

@Trott Trott commented Mar 28, 2023

No description provided.

@Trott Trott marked this pull request as ready for review March 28, 2023 13:31
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 28, 2023
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

Fast-track has been requested by @Trott. Please 👍 to approve.

mhdawson
mhdawson approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 28, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 28, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/47282
✔  Done loading data for nodejs/node/pull/47282
----------------------------------- PR info ------------------------------------
Title      doc: fix typo in SECURITY.md (#47282)
Author     Rich Trott  (@Trott)
Branch     Trott:Trott-patch-1 -> nodejs:main
Labels     doc, fast-track
Commits    1
 - doc: fix typo in SECURITY.md
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/47282
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47282
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 28 Mar 2023 13:31:38 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361095224
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361352729
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361397071
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361471612
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4546278083

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 28, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 28, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/47282
✔  Done loading data for nodejs/node/pull/47282
----------------------------------- PR info ------------------------------------
Title      doc: fix typo in SECURITY.md (#47282)
Author     Rich Trott  (@Trott)
Branch     Trott:Trott-patch-1 -> nodejs:main
Labels     doc, fast-track
Commits    1
 - doc: fix typo in SECURITY.md
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/47282
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47282
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 28 Mar 2023 13:31:38 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361095224
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361352729
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361397071
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47282#pullrequestreview-1361471612
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4546948764

@Trott
doc: fix typo in SECURITY.md
da2210e 
PR-URL: #47282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott merged commit da2210e into main Mar 28, 2023
@Trott
Copy link
Member Author

Trott commented Mar 28, 2023

Landed in da2210e

@Trott Trott deleted the Trott-patch-1 branch March 28, 2023 19:43
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@Trott @RafaelGSS
doc: fix typo in SECURITY.md
89a9660 
PR-URL: #47282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@Trott @RafaelGSS
doc: fix typo in SECURITY.md
4a953a0 
PR-URL: #47282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@Trott @RafaelGSS
doc: fix typo in SECURITY.md
bac893a 
PR-URL: #47282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@Trott @danielleadams
doc: fix typo in SECURITY.md
81ebaf2 
PR-URL: #47282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott @nodejs-github-bot @lpinca @cjihrig @tniessen @mhdawson @debadree25