-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: avoid usage of pipes library #47271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python's `pipes` library is deprecated and will be removed in Python version 3.13, so remove it's import and replace `pipes.quote()` with `shlex.quote()`.
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
labels
Mar 27, 2023
lpinca
approved these changes
Mar 27, 2023
anonrig
approved these changes
Mar 27, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 28, 2023
debadree25
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 28, 2023
debadree25
approved these changes
Mar 29, 2023
debadree25
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 29, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 29, 2023
Landed in ae4f041 |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Python's `pipes` library is deprecated and will be removed in Python version 3.13, so remove it's import and replace `pipes.quote()` with `shlex.quote()`. PR-URL: #47271 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
Python's `pipes` library is deprecated and will be removed in Python version 3.13, so remove it's import and replace `pipes.quote()` with `shlex.quote()`. PR-URL: #47271 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Python's `pipes` library is deprecated and will be removed in Python version 3.13, so remove it's import and replace `pipes.quote()` with `shlex.quote()`. PR-URL: #47271 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Python's `pipes` library is deprecated and will be removed in Python version 3.13, so remove it's import and replace `pipes.quote()` with `shlex.quote()`. PR-URL: #47271 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's
pipes
library is deprecated and will be removed in Python version 3.13, so remove it's import and replacepipes.quote()
withshlex.quote()
.