deps: V8: cherry-pick 975ff4dbfd1b#47209
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 24, 2023
Merged
Conversation
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
targos
approved these changes
Mar 22, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
gengjiawen
approved these changes
Mar 22, 2023
debadree25
added
the
author ready
richardlau
approved these changes
Mar 22, 2023
debadree25
added
the
commit-queue
ErickWendel
approved these changes
Mar 23, 2023
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8e203f1 |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
PR-URL: #47209
Fixes: #41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
PR-URL: #47209
Fixes: #41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
PR-URL: #47209
Fixes: #41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
PR-URL: #47209
Fixes: #41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@975ff4d
Fixes: #41714