-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: document process for sharing project news #47189
Conversation
Fixes: nodejs/TSC#1333 Signed-off-by: Michael Dawson <mdawson@devrus.com>
Review requested:
|
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: Gireesh Punathil <gpunathi@in.ibm.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
|
||
The project's approach is as follows: | ||
|
||
* The project will create one "What's new in YYYY" issue in the `nodejs/node` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An issue seems like the wrong tool for the job. Would a GitHub discussion item be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm if ok if a discussion item is better for the core repo. Updating
Co-authored-by: Rich Trott <rtrott@gmail.com>
@Trott believe I've addressed your comments/suggestions. |
The project's approach is as follows: | ||
|
||
* The project will create one "What's new in YYYY" discussion item in | ||
the `nodejs/node` repo for news related to Node.js core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be better to use a separate repo for these news. In this way, publications could subscribe to the notifications on that repository to receive the updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could make it easier for publications but the goal is to make it easy for the teams and the project both in terms of workflow and discoverability. In the case of the node-api team looking for an issue in a different repo would be more work due to the way we use a milestone to review work each week.
Even if there was a separate repo the ask was not that a new issue be created for each piece of news, only update an existing issue/discussion so once the publication subscribes to an issue I don't think it will be any different in respect to notifications.
Therefore I think using an issue/discussion item in the existing repos is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!!
Fixes: nodejs/TSC#1333 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47189 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in 67660e8 |
Fixes: nodejs/TSC#1333 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47189 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: nodejs/TSC#1333 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47189 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: nodejs/TSC#1333 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47189 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: nodejs/TSC#1333 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47189 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: nodejs/TSC#1333