Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: don't reset embeder signal handlers #47188

Merged
merged 1 commit into from
Mar 31, 2023
Merged

src: don't reset embeder signal handlers #47188

merged 1 commit into from
Mar 31, 2023

Commits on Mar 22, 2023

  1. src: don't reset embeder signal handlers 

    The only bad handler value we can inhert from before exec is SIG_IGN
(any actual function pointer is reset to SIG_DFL during exec).
If that's the case, we want to reset it back to SIG_DFL.
However, it's also possible that an embeder (or an LD_PRELOAD-ed
library) has set up own signal handler for own purposes
(e.g. profiling). If that's the case, keep it intact.

Fix nodejs#47013
    @dvyukov
    dvyukov committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    b82360a View commit details
    Browse the repository at this point in the history