bootstrap: bind properties of the global console in the default snapshot#47171
Open
joyeecheung wants to merge 1 commit intonodejs:mainfrom
Open
bootstrap: bind properties of the global console in the default snapshot#47171joyeecheung wants to merge 1 commit intonodejs:mainfrom
joyeecheung wants to merge 1 commit intonodejs:mainfrom
Conversation
If it safe to bind the properties of the global console when building the default snapshot as long as they are not actually accessed during snapshot building. Bind them early instead of doing it at run time.
nodejs-github-bot
added
console
Collaborator
19 tasks
Collaborator
This was referenced Mar 22, 2023
legendecas
approved these changes
Mar 27, 2023
Collaborator
Contributor
|
@joyeecheung I've noticed Windows CI failed for this PR. This happened because this commit is missing from your branch. Please rebase onto the latest main to fix this. |
18 tasks
Contributor
|
This needs a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it safe to bind the properties of the global console when building the default snapshot as long as they are not actually accessed during snapshot building. Bind them early instead of doing it at run time.