Skip to content

Conversation

joyeecheung
Copy link
Member

If it safe to bind the properties of the global console when building the default snapshot as long as they are not actually accessed during snapshot building. Bind them early instead of doing it at run time.

If it safe to bind the properties of the global console when building
the default snapshot as long as they are not actually accessed during
snapshot building. Bind them early instead of doing it at run time.
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. labels Mar 20, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@StefanStojanovic
Copy link
Contributor

@joyeecheung I've noticed Windows CI failed for this PR. This happened because this commit is missing from your branch. Please rebase onto the latest main to fix this.

@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

This needs a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants