Commits on Mar 17, 2023

1. test: fix 'checks' validation test for checkPrime …

   This test had two problems:
   
   * The first argument was a number in both cases, which is what caused
     the (expected) ERR_INVALID_ARG_TYPE error -- the validity of the
     'checks' option was not actually verified at all. Thus, the first
     argument should be valid for this particular test.
   * The function returned by common.mustNotCall() was passed to
     assert.throws() as a third argument instead of being passed to
     checkPrime() as a third argument. (Isn't JavaScript great?) This again
     led to the (expected) ERR_INVALID_ARG_TYPE error, but again, the
     validity of the 'checks' option was not verified.
   
   Fix both issues by ensuring that all arguments except the 'checks'
   option are valid.
   
   Refs: nodejs#36997

   

   tniessen committed Mar 17, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 2416f78
   • Browse repository at this point

   Copy the full SHA

   2416f78 View commit details

   Browse the repository at this point in the history