doc: rename the startup performance initiative to startup snapshot #47111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
|
Review requested:
|
legendecas
approved these changes
Mar 16, 2023
RafaelGSS
approved these changes
Mar 16, 2023
RaisinTen
approved these changes
Mar 16, 2023
BethGriggs
approved these changes
Mar 16, 2023
cjihrig
approved these changes
Mar 16, 2023
tniessen
approved these changes
Mar 16, 2023
lpinca
approved these changes
Mar 16, 2023
anonrig
approved these changes
Mar 17, 2023
legendecas
added
commit-queue
aymen94
approved these changes
Mar 17, 2023
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
…47111) The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
|
This was landed without commit metadata, but that happened 13 hours ago and 2 other commits were landed on top of it. I don't know if we can still force-push... |
|
@targos can we enable GitHub's "Require status checks to pass before merging" and post a required status report that never passes to block the "merge" button? This still allows node-core-util to land commits since it pushes to the main branch directly. |
|
Not really. The commit queue uses the "squash and merge" button (with a GitHub API call) |
|
Also, if you require status checks to pass before merging, it becomes impossible to push a commit directly, as it wouldn't have the required check. |
|
good to know that. thanks for the explanation! |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
…47111) The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
…47111) The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
…47111) The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot".
Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.