test_runner: stringify AssertError expected and actual#47088
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 4, 2023
Merged
test_runner: stringify AssertError expected and actual#47088nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
MoLow
commented
Mar 14, 2023
aduh95
reviewed
Mar 14, 2023
cjihrig
reviewed
Mar 14, 2023
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
I think this change might work, but I think it's incomplete without a context object. I also worry about how the stringify change might interact with large objects.
I'm not 100% if it would be valid YAML, but if it is, maybe actual and expected should add another level of indentation instead of just trying to stringify.
MoLow
force-pushed
the
stringify-assert-error-props
branch
3 times, most recently
from
6a60ab8 to
b6d1159
Compare
MoLow
force-pushed
the
stringify-assert-error-props
branch
from
b6d1159 to
b540361
Compare
cjihrig
approved these changes
Apr 2, 2023
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Sorry for the delay. LGTM
MoLow
force-pushed
the
stringify-assert-error-props
branch
from
b540361 to
8840601
Compare
github-actions
bot
removed
the
request-ci
Collaborator
ljharb
approved these changes
Apr 3, 2023
Collaborator
Collaborator
29 tasks
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 102540a |
26 tasks
Merged
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47088 Fixes: nodejs#47075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #47075