Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in test.md #47053

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix typo in test.md #47053

merged 1 commit into from
Mar 13, 2023

Conversation

vhiairrassary
Copy link
Contributor

Fix typo in test.md (invalid case).

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v14.x test_runner Issues and PRs related to the test runner subsystem. labels Mar 12, 2023
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2023
@benjamingr benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1ef4faa into nodejs:main Mar 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1ef4faa

@vhiairrassary vhiairrassary deleted the patch-1 branch March 13, 2023 12:16
targos pushed a commit that referenced this pull request Mar 13, 2023
@vhiairrassary @targos
doc: fix typo in test.md
1e8fe6f 
PR-URL: #47053
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@vhiairrassary @targos
doc: fix typo in test.md
89f31a1 
PR-URL: #47053
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@vhiairrassary @danielleadams
doc: fix typo in test.md
01d8267 
PR-URL: #47053
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber juliangruber approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vhiairrassary @nodejs-github-bot @juliangruber @Trott @benjamingr @cjihrig @Ayase-252 @MoLow