Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: port js2c.py to C++ #46997

Closed
wants to merge 4 commits into from
Closed

tools: port js2c.py to C++ #46997

wants to merge 4 commits into from

Commits on May 13, 2023

  1. tools: port js2c.py to C++ 

    This makes it easier to use third-party dependencies in this tool
(e.g. adding compression using algorithms not available in Python).
It is also much faster - locally js2c.py takes ~1.5s to generate the
output whereas this version takes ~0.1s - and consumes less memory
(~110MB v.s. 66MB).

This also modifies the js2c.py a bit to simplify the output, making
it easier to compare with one generated by the C++ version. Locally
the output from the two are identical. We'll remove js2c.py in a
subsequent commit when the C++ version is used by default.
    @joyeecheung
    joyeecheung committed May 13, 2023
    Configuration menu
    Copy the full SHA
    cad0468 View commit details
    Browse the repository at this point in the history

  2. build: replace js2c.py with js2c.cc

    @joyeecheung
    joyeecheung committed May 13, 2023
    Configuration menu
    Copy the full SHA
    df3d5ba View commit details
    Browse the repository at this point in the history

  3. fixup! tools: port js2c.py to C++

    @joyeecheung
    joyeecheung committed May 13, 2023
    Configuration menu
    Copy the full SHA
    09d606c View commit details
    Browse the repository at this point in the history

  4. build: support --root in js2c.cc

    @joyeecheung
    joyeecheung committed May 13, 2023
    Configuration menu
    Copy the full SHA
    39dafd0 View commit details
    Browse the repository at this point in the history