Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for custom loader hooks with permission model #46977

Merged
merged 1 commit into from
Mar 8, 2023
Merged

test: add coverage for custom loader hooks with permission model #46977

merged 1 commit into from
Mar 8, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 6, 2023

No description provided.

@aduh95 aduh95 requested a review from targos March 6, 2023 17:10
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 6, 2023

/cc @nodejs/loaders

@bmeck
Copy link
Member

bmeck commented Mar 6, 2023 via email

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
JakobJingleheimer
JakobJingleheimer approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@github-actions github-actions bot mentioned this pull request Mar 7, 2023
Open
19 tasks
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50247/

@github-actions github-actions bot mentioned this pull request Mar 8, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50275/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit b8ef1b4 into nodejs:main Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b8ef1b4

@aduh95 aduh95 deleted the hooks-permissions branch March 8, 2023 18:02
This was referenced Mar 9, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
test: add coverage for custom loader hooks with permission model
63544b7 
PR-URL: #46977
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
@RafaelGSS RafaelGSS added backport-blocked-v16.x backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. and removed dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. backport-blocked-v16.x backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels Apr 3, 2023
@tniessen tniessen added the permission Issues and PRs related to the Permission Model label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aduh95 @bmeck @nodejs-github-bot @GeoffreyBooth @targos @cjihrig @JakobJingleheimer @tniessen @RafaelGSS