Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix DOMException property descriptors after being lazy loaded #46799

Merged
merged 2 commits into from
Feb 25, 2023
Merged

lib: fix DOMException property descriptors after being lazy loaded #46799

merged 2 commits into from
Feb 25, 2023

Conversation

panva
Copy link
Member

@panva panva commented Feb 23, 2023

Fixes DOMException property descriptors after they being lazy loaded the first time.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 23, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49955/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2023
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
joyeecheung
joyeecheung approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion

lib/internal/bootstrap/browser.js Outdated Show resolved Hide resolved
@panva @joyeecheung
Update lib/internal/bootstrap/browser.js
50d510a 
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@panva panva added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49976/

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit f85113b into nodejs:main Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f85113b

@panva panva deleted the fix-domexception-global-wpt branch February 25, 2023 17:22
targos pushed a commit that referenced this pull request Mar 13, 2023
@panva @targos
lib: fix DOMException property descriptors after being lazy loaded
812c84b 
PR-URL: #46799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Mar 14, 2023
@panva @targos
lib: fix DOMException property descriptors after being lazy loaded
281f176 
PR-URL: #46799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Apr 11, 2023
@danielleadams
Copy link
Contributor

@panva this also broke builds in the v18.x-staging branch. Could you open a backport PR? Thank you

@panva
Copy link
Member Author

panva commented Apr 11, 2023

Backport depends on #46425

@panva panva added backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Apr 11, 2023
targos pushed a commit that referenced this pull request Nov 10, 2023
@panva @targos
lib: fix DOMException property descriptors after being lazy loaded
671d2c0 
PR-URL: #46799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
lib: fix DOMException property descriptors after being lazy
3ab3f4d 
PR-URL: nodejs/node#46799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
lib: fix DOMException property descriptors after being lazy
baedf97 
PR-URL: nodejs/node#46799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@panva @nodejs-github-bot @danielleadams @jasnell @tniessen @joyeecheung @legendecas