-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve control flow in test-tls-dhe #46751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this test fails, e.g., if the s_client output does not match the expectation, the previous implementation would not produce any helpful error messages. Rework the control flow to be more idiomatic. Avoid callback chaining and stream operations. Also, the TLS server 'close' event does not pass an error to the event handler, so remove the respective assertion.
tniessen
added
tls
Issues and PRs related to the tls subsystem.
test
Issues and PRs related to the tests.
labels
Feb 21, 2023
lpinca
approved these changes
Feb 21, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 21, 2023
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 21, 2023
This was referenced Feb 22, 2023
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Feb 23, 2023
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: nodejs#46751
jasnell
approved these changes
Feb 24, 2023
tniessen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 24, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 24, 2023
Landed in d953049 |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Mar 2, 2023
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: nodejs#46751
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Mar 5, 2023
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: nodejs#46751
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Mar 9, 2023
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: nodejs#46751 PR-URL: nodejs#46963 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
If this test fails, e.g., if the s_client output does not match the expectation, the previous implementation would not produce any helpful error messages. Rework the control flow to be more idiomatic. Avoid callback chaining and stream operations. Also, the TLS server 'close' event does not pass an error to the event handler, so remove the respective assertion. PR-URL: #46751 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
If this test fails, e.g., if the s_client output does not match the expectation, the previous implementation would not produce any helpful error messages. Rework the control flow to be more idiomatic. Avoid callback chaining and stream operations. Also, the TLS server 'close' event does not pass an error to the event handler, so remove the respective assertion. PR-URL: #46751 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
tls
Issues and PRs related to the tls subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this test fails, e.g., if the
s_client
output does not match the expectation, the previous implementation would not produce any helpful error messages. Rework the control flow to be more idiomatic. Avoid the'exit'
event handler, unnecessaryRegExp
, callback chaining, and stream operations. Also, the TLS server'close'
event does not pass an error to the event handler, so remove the respective assertion.