[v18.x] deps: patch V8 to 10.2.154.26

[targos]

Refs: v8/v8@10.2.154.23...10.2.154.26

[nodejs-github-bot]

Review requested:

• @nodejs/v8-update

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49286/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5152/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5152/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5152/

[targos]

Landed in 0f29b57

[kleisauke]

FYI: the change in deps/v8/src/compiler/backend/x64/code-generator-x64.cc causes issues on various WebAssembly projects. Cherry-picking commit v8/v8@9ec4e90 would probably fix that. See https://crbug.com/1407594 for details.

[targos]

I wonder if this affects ChromeOS 102. It is still in LTS until Mar 9 2023 so I would expect Google to backport the fix in V8.

[kibertoad]

@targos what was fixed in this patch, and how important is it for existing 18.4.1 prod deployments?

[kleisauke]

For reference, here's a simple reproducer based on the testcase in the above-mentioned V8 commit:

$ curl -LO https://gist.github.com/kleisauke/0084ac571832295019bf5feca99ada02/raw/a42c0cd38f8d402d2a87b9d8017c075be8542767/spiller.wasm
$ node -v
v18.14.1
$ node --noliftoff -e "WebAssembly.instantiate(fs.readFileSync('./spiller.wasm')).then(obj => console.log(obj.instance.exports.main().toString(16)))"
12345678000000
$ node -v
v18.14.2
$ node --noliftoff -e "WebAssembly.instantiate(fs.readFileSync('./spiller.wasm')).then(obj => console.log(obj.instance.exports.main().toString(16)))"
5678000000

(see https://gist.github.com/kleisauke/0084ac571832295019bf5feca99ada02 for the .wat file)

And here's a more complicated reproducer:

Details

$ mkdir wasm-vips-test && cd wasm-vips-test
$ npm init -y
$ npm install wasm-vips
$ curl -LO https://github.com/kleisauke/wasm-vips/raw/master/test/unit/images/sample.png
$ cat <<EOT > test.mjs
import Vips from 'wasm-vips';

const vips = await Vips();

const im = vips.Image.newFromFile('sample.png', {
  fail_on: 'warning'
});
console.log(im.avg());

im.delete();
vips.shutdown();
EOT

$ node -v
v18.14.1
$ node test.mjs
30498.1968091746
$ node -v
v18.14.2
$ node test.mjs
(process:42): VIPS-WARNING **: 17:36:33.618: pngload: invalid scanline filter

(process:42): VIPS-WARNING **: 17:36:33.625: error in tile 0 x 48

...

Error: unable to call avg
pngload: libspng read error