wasi: add wasi sock_accept stub by mhdawson · Pull Request #46434 · nodejs/node

mhdawson · 2023-01-31T00:30:28Z

Add stub for sock_accept so that we have stubs
for all of the sock methods in wasi_snapshot_preview1.
Its a bit awkward as the method was added after the
initial definitial of wasi_snapshot-preview1 but I
think it should be semver minor at most to add
the method.

Depends on nodejs/uvwasi#185
being landed in uvwasi first and an updated version
of uvwasi that includes that being pulled into
Node.js

Signed-off-by: Michael Dawson mdawson@devrus.com

nodejs-github-bot · 2023-01-31T00:30:33Z

Review requested:

@nodejs/wasi

cjihrig

LGTM with minor comments.

src/node_wasi.cc

src/node_wasi.h

test/wasi/c/sock.c

mhdawson · 2023-01-31T22:03:27Z

Pushed commit to address all comment so far.

mhdawson · 2023-01-31T22:04:09Z

As mentioned needs an updated version of uvwasi before tests will pass.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com>

mhdawson · 2023-02-23T23:13:18Z

Just added commit to update uvwasi to v0.0.16 so that tests can pass.

@cjihrig a re-LGTM from you might make sense due to that addition.

nodejs-github-bot · 2023-02-23T23:21:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49958/

cjihrig

The release commit LGTM. Assuming the other commit hasn't changed, the PR LGTM

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

mhdawson · 2023-03-01T17:38:49Z

Landed in 8e4fa26...bd04106

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

danielleadams · 2023-04-03T02:41:00Z

@mhdawson this didn't land cleanly on v18.x-staging. Do you mind opening a backport PR to v18.x? Thank you

mhdawson · 2023-04-04T21:49:44Z

@danielleadams thanks for the head up. Will add it to my list of things.

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#46434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

mhdawson · 2023-04-06T18:20:00Z

@danielleadams PR for backport - #47455

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Backport-PR-URL: #47455 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Backport-PR-URL: #47455 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#46434 Backport-PR-URL: nodejs#47455 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#46434 Backport-PR-URL: nodejs#47455 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. wasi Issues and PRs related to the WebAssembly System Interface. labels Jan 31, 2023

mhdawson removed the wasi Issues and PRs related to the WebAssembly System Interface. label Jan 31, 2023

mhdawson force-pushed the wasi-sockets2 branch from 6f3a82a to e6d345b Compare January 31, 2023 00:34

mhdawson added the wasi Issues and PRs related to the WebAssembly System Interface. label Jan 31, 2023

mhdawson changed the title ~~Wasi sockets2~~ wasi: add wasi sock_accept stub Jan 31, 2023

mhdawson force-pushed the wasi-sockets2 branch from e6d345b to 16fbfbe Compare January 31, 2023 00:48

jasnell approved these changes Jan 31, 2023

View reviewed changes

cjihrig approved these changes Jan 31, 2023

View reviewed changes

src/node_wasi.cc Outdated Show resolved Hide resolved

src/node_wasi.cc Outdated Show resolved Hide resolved

src/node_wasi.h Outdated Show resolved Hide resolved

test/wasi/c/sock.c Outdated Show resolved Hide resolved

test/wasi/c/sock.c Outdated Show resolved Hide resolved

mhdawson commented Jan 31, 2023

View reviewed changes

test/wasi/c/sock.c Outdated Show resolved Hide resolved

mhdawson mentioned this pull request Feb 17, 2023

uvwasi team working tasks nodejs/uvwasi#187

Closed

mhdawson added 2 commits February 23, 2023 17:55

deps: update uvwasi to v0.0.16

1e73745

Signed-off-by: Michael Dawson <mdawson@devrus.com>

mhdawson force-pushed the wasi-sockets2 branch from 318cf2f to 5e2de27 Compare February 23, 2023 23:12

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023

cjihrig approved these changes Feb 23, 2023

View reviewed changes

mhdawson added a commit that referenced this pull request Mar 1, 2023

deps: update uvwasi to v0.0.16

b185e97

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

mhdawson closed this Mar 1, 2023

targos pushed a commit that referenced this pull request Mar 13, 2023

deps: update uvwasi to v0.0.16

dc4c5f5

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos pushed a commit that referenced this pull request Mar 14, 2023

deps: update uvwasi to v0.0.16

7ab7f97

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos mentioned this pull request Mar 14, 2023

v19.8.0 release proposal #47087

Merged

danielleadams added the backport-requested-v18.x label Apr 3, 2023

mhdawson added backported-to-v18.x and removed backport-requested-v18.x labels Apr 6, 2023

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Uh oh!

Conversation

mhdawson commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 31, 2023

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhdawson commented Jan 31, 2023

Uh oh!

mhdawson commented Jan 31, 2023

Uh oh!

mhdawson commented Feb 23, 2023

Uh oh!

nodejs-github-bot commented Feb 23, 2023

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Mar 1, 2023

Uh oh!

danielleadams commented Apr 3, 2023

Uh oh!

mhdawson commented Apr 4, 2023

Uh oh!

mhdawson commented Apr 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mhdawson commented Jan 31, 2023 •

edited

Loading