test: remove duplicate fork module import #4634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fork` is imported twice in a row. Remove duplication.
|
LGTM |
mscdex
added
the
child_process
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
targos
pushed a commit
that referenced
this pull request
Jan 12, 2016
`fork` is imported twice in a row. Remove duplication. PR-URL: #4634 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
|
landed in 0f3d75e |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2016
`fork` is imported twice in a row. Remove duplication. PR-URL: #4634 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Merged
|
another fix has already landed on LTS making this one moot. Adding to ignore list |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
`fork` is imported twice in a row. Remove duplication. PR-URL: nodejs#4634 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forkis imported twice in a row. Remove duplication.