test: enable more case of bad buffer in fs.write
#46236
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing to the `string` parameter an object with an own `toString` function is no longer supported.(DEP0162) So use such case as bad buffer in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/deprecations.md#dep0162-fswrite-fswritefilesync-coercion-to-string
nodejs-github-bot
added
needs-ci
LiviaMedeiros
approved these changes
Jan 17, 2023
LiviaMedeiros
added
request-ci
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jan 17, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 49be0ac |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Passing to the `string` parameter an object with an own `toString` function is no longer supported.(DEP0162) So use such case as bad buffer in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/deprecations.md#dep0162-fswrite-fswritefilesync-coercion-to-string PR-URL: #46236 Refs: #42796 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing to the
stringparameter an object with an owntoStringfunction is no longer supported.(DEP0162)So use such case as bad buffer in test.
Refs: https://github.com/nodejs/node/blob/main/doc/api/deprecations.md#dep0162-fswrite-fswritefilesync-coercion-to-string
Refs: #42796