-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
doc: add v8 fast api contribution guidelines #46199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f4c05cb
b79e5c8
20446b5
9acab7d
cb3f47a
269c8f2
a2e2d67
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
# Adding V8 Fast API | ||
|
||
Node.js uses [V8](https://v8.dev/) as its JavaScript engine. | ||
Embedding functions implemented in C++ incur a high overhead, so V8 | ||
provides an API to implement native functions which may be invoked directly | ||
from JITted code. These functions also come with additional constraints, | ||
for example, they may not trigger garbage collection. | ||
|
||
## Limitations | ||
|
||
* Fast API functions may not trigger garbage collection. This means by proxy | ||
that JavaScript execution and heap allocation are also forbidden, including | ||
`v8::Array::Get()` or `v8::Number::New()`. | ||
* Throwing errors is not available from within a fast API call, but can be done | ||
through the fallback to the slow API. | ||
* Not all parameter and return types are supported in fast API calls. | ||
For a full list, please look into | ||
[`v8-fast-api-calls.h`](../../deps/v8/include/v8-fast-api-calls.h). | ||
|
||
## Requirements | ||
|
||
* Any function passed to `CFunction::Make`, including fast API function | ||
declarations, should have their signature registered in | ||
[`node_external_reference.h`](../../src/node_external_reference.h) file. | ||
Although, it would not start failing or crashing until the function ends up | ||
in a snapshot (either the built-in or a user-land one). Please refer to the | ||
[binding functions documentation](../../src#binding-functions) for more | ||
information. | ||
* To test fast APIs, make sure to run the tests in a loop with a decent | ||
iterations count to trigger relevant optimizations that prefer the fast API | ||
over the slow one. | ||
* The fast callback must be idempotent up to the point where error and fallback | ||
conditions are checked, because otherwise executing the slow callback might | ||
produce visible side effects twice. | ||
|
||
## Fallback to slow path | ||
|
||
Fast API supports fallback to slow path for when it is desirable to do so, | ||
for example, when throwing a custom error or executing JavaScript code is | ||
needed. The fallback mechanism can be enabled and changed from the C++ | ||
implementation of the fast API function declaration. | ||
|
||
Passing `true` to the `fallback` option will force V8 to run the slow path | ||
with the same arguments. | ||
|
||
In V8, the options fallback is defined as `FastApiCallbackOptions` inside | ||
[`v8-fast-api-calls.h`](../../deps/v8/include/v8-fast-api-calls.h). | ||
RaisinTen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
* C++ land | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this a bullet point? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It aligns with other sections in the same file for mentioning the context of the example it's referring to. Do you have a recommendation for an alternative? |
||
|
||
Example of a conditional fast path on C++ | ||
|
||
```cpp | ||
// Anywhere in the execution flow, you can set fallback and stop the execution. | ||
static double divide(const int32_t a, | ||
const int32_t b, | ||
v8::FastApiCallbackOptions& options) { | ||
if (b == 0) { | ||
options.fallback = true; | ||
anonrig marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return 0; | ||
} else { | ||
return a / b; | ||
} | ||
} | ||
``` | ||
|
||
## Example | ||
|
||
A typical function that communicates between JavaScript and C++ is as follows. | ||
|
||
* On the JavaScript side: | ||
|
||
```js | ||
const { divide } = internalBinding('custom_namespace'); | ||
``` | ||
|
||
* On the C++ side: | ||
|
||
```cpp | ||
#include "v8-fast-api-calls.h" | ||
|
||
namespace node { | ||
namespace custom_namespace { | ||
|
||
static void SlowDivide(const FunctionCallbackInfo<Value>& args) { | ||
Environment* env = Environment::GetCurrent(args); | ||
CHECK_GE(args.Length(), 2); | ||
CHECK(args[0]->IsInt32()); | ||
anonrig marked this conversation as resolved.
Show resolved
Hide resolved
|
||
CHECK(args[1]->IsInt32()); | ||
auto a = args[0].As<v8::Int32>(); | ||
auto b = args[1].As<v8::Int32>(); | ||
|
||
if (b->Value() == 0) { | ||
return node::THROW_ERR_INVALID_STATE(env, "Error"); | ||
anonrig marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
double result = a->Value() / b->Value(); | ||
args.GetReturnValue().Set(v8::Number::New(env->isolate(), result)); | ||
} | ||
|
||
static double FastDivide(const int32_t a, | ||
const int32_t b, | ||
v8::FastApiCallbackOptions& options) { | ||
if (b == 0) { | ||
options.fallback = true; | ||
anonrig marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return 0; | ||
} else { | ||
return a / b; | ||
} | ||
} | ||
|
||
CFunction fast_divide_(CFunction::Make(FastDivide)); | ||
RaisinTen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
static void Initialize(Local<Object> target, | ||
Local<Value> unused, | ||
Local<Context> context, | ||
void* priv) { | ||
SetFastMethod(context, target, "divide", SlowDivide, &fast_divide_); | ||
} | ||
|
||
void RegisterExternalReferences(ExternalReferenceRegistry* registry) { | ||
registry->Register(SlowDivide); | ||
registry->Register(FastDivide); | ||
registry->Register(fast_divide_.GetTypeInfo()); | ||
} | ||
|
||
} // namespace custom_namespace | ||
} // namespace node | ||
|
||
NODE_BINDING_CONTEXT_AWARE_INTERNAL(custom_namespace, | ||
node::custom_namespace::Initialize); | ||
NODE_BINDING_EXTERNAL_REFERENCE( | ||
custom_namespace, | ||
node::custom_namespace::RegisterExternalReferences); | ||
``` | ||
|
||
* Update external references ([`node_external_reference.h`](../../src/node_external_reference.h)) | ||
|
||
Since our implementation used | ||
`double(const int32_t a, const int32_t b, v8::FastApiCallbackOptions& options)` | ||
signature, we need to add it to external references and in | ||
`ALLOWED_EXTERNAL_REFERENCE_TYPES`. | ||
|
||
Example declaration: | ||
|
||
```cpp | ||
using CFunctionCallbackReturningDouble = double (*)(const int32_t a, | ||
const int32_t b, | ||
v8::FastApiCallbackOptions& options); | ||
``` | ||
anonrig marked this conversation as resolved.
Show resolved
Hide resolved
|
Uh oh!
There was an error while loading. Please reload this page.