Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: update exit codes #45841

Merged
merged 8 commits into from
Feb 26, 2023
Merged

lib,src: update exit codes #45841

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
057da6e
lib,src: update exit codes as per todos
debadree25 Dec 13, 2022
488cefb
test: update tests accordingly
debadree25 Dec 13, 2022
771b4fd
remove TODO comments
debadree25 Dec 13, 2022
7b22b42
src: update comment
debadree25 Dec 13, 2022
f4f6b6b
src,test: update snapshot failure in node.cc and associated test
debadree25 Dec 13, 2022
aaa272e
src: fix cpp linting
debadree25 Dec 13, 2022
0a1a5a3
fixup! lint fix
debadree25 Feb 19, 2023
f758e22
fixup! test-snapshot-basic
debadree25 Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: update tests accordingly
  • Loading branch information
@debadree25
debadree25 committed Feb 19, 2023
commit 488cefb202f8b89983c2d2fb072996bd73c578f7
2 changes: 1 addition & 1 deletion test/parallel/test-snapshot-incompatible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const entry = fixtures.path('empty.js');

const stderr = child.stderr.toString().trim();
assert.match(stderr, /Failed to load the startup snapshot/);
assert.strictEqual(child.status, 1);
assert.strictEqual(child.status, 14);
}

{
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-invalid-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const assert = require('assert');
(async () => {
const cli = startCLI([]);
const code = await cli.quit();
assert.strictEqual(code, 1);
assert.strictEqual(code, 9);
assert.match(cli.output, /^Usage:/, 'Prints usage info');
})().then(common.mustCall());

Expand Down