doc: promote fetch/webstreams from experimental to stable by styfle · Pull Request #45684 · nodejs/node

styfle · 2022-11-30T01:03:14Z

This PR implements documentation changes related to #45287

Text for the notable-change label:

The fetch() implementation in Node.js becomes stable. It currently passes 1282 of the 1453 applicable tests, having a 88.2% pass rate.

This impacts Web Streams, FormData, Headers, Request, Response, fetch.

This PR implements documentation changes related to nodejs#45287

doc/api/cli.md

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

aduh95

Adding request change to make sure this doesn't land without approval from @nodejs/undici. I wonder if it makes sense to keep --no-experimental-fetch around if we think fetch is stable.

mcollina · 2022-12-01T13:08:38Z

@styfle we explicitly did not mark it as stable because there are still a few things that needs fixing before we mark it stable. However it's ready for general use.

For more context:

targos · 2022-12-01T13:41:42Z

I wonder if it makes sense to keep --no-experimental-fetch around if we think fetch is stable.

I'm afraid to remove it in a non-major release. Some people may need it if they are using polyfills that behave differently.

aduh95 · 2022-12-19T22:41:35Z

This was discussed in a previous TSC meeting, some have said that Web Streams would need to graduate to stable at the same time as fetch. I for one don't know whether Web Streams are ready to graduate to stable, hopefully @ronag has some thoughts on this.

mcollina

As I said in nodejs/undici#1737 (comment), we should wait for whatwg/fetch#973 and getSetCookie() or any other solution for that problem.

Also WHATWG Streams should graduate as well.

mhdawson · 2023-01-04T17:01:14Z

Discussed in TSC meeting today, removed agenda tag.

KhafraDev · 2023-01-04T17:10:49Z

we should wait for whatwg/fetch#973 and getSetCookie() or any other solution for that problem.

@mcollina - it's unlikely we'll ever get a solution, unless wintercg decides to author it. Browsers aren't interested in implementing it, keeping the proposal held up. Makes sense, I guess - this is really only useful in server environments. From the issue linked:

It's currently stuck on getting implementer interest from two browsers.

mcollina · 2023-01-05T09:07:39Z

@KhafraDev let's do getSetCookie like Deno does, ie https://deno.land/std@0.170.0/http/cookie.ts.

piranna · 2023-01-18T19:03:25Z

Is Node.js fetch() implementation full-duplex? Or just half-duplex as (all?) browsers ones?

KhafraDev · 2023-01-18T19:36:28Z

It's full duplex, which isn't spec compliant.

nodejs-github-bot · 2023-09-24T11:29:59Z

Commit Queue failed

- Loading data for nodejs/node/pull/45684
✔  Done loading data for nodejs/node/pull/45684
----------------------------------- PR info ------------------------------------
Title      doc: promote fetch/webstreams from experimental to stable (#45684)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     styfle:fix-docs-remove-experimental -> nodejs:main
Labels     doc, notable-change, commit-queue-squash
Commits    8
 - doc: change fetch from experimental to stable
 - doc: add "exposition"
 - Merge branch 'main' into fix-docs-remove-experimental
 - doc: change web streams from experimental to stable
 - doc: global fetch version history
 - doc: webstreams version history
 - doc: update pr url
 - doc: more globals version history
Committers 2
 - Steven 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/45684
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Robert Nagy 
Reviewed-By: James M Snell 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Moshe Atlow 
Reviewed-By: Matteo Collina 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45684
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Robert Nagy 
Reviewed-By: James M Snell 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Moshe Atlow 
Reviewed-By: Matteo Collina 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 30 Nov 2022 01:03:14 GMT
   ✔  Approvals: 8
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/45684#pullrequestreview-1200197188
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45684#pullrequestreview-1641039600
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/45684#pullrequestreview-1200678894
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45684#pullrequestreview-1223280615
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/45684#pullrequestreview-1633787405
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/45684#pullrequestreview-1633820238
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45684#pullrequestreview-1637138795
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/45684#pullrequestreview-1638394013
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 45684
From https://github.com/nodejs/node
 * branch                  refs/pull/45684/merge -> FETCH_HEAD
✔  Fetched commits as c9e72e34abec..a2075bccb18f
--------------------------------------------------------------------------------
Auto-merging doc/api/cli.md
CONFLICT (content): Merge conflict in doc/api/cli.md
Auto-merging doc/api/globals.md
error: could not apply bddf8ce266... doc: change fetch from experimental to stable
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/6289763282

aduh95 · 2023-09-24T21:11:08Z

Landed in 740ca54

KhafraDev · 2023-09-24T22:14:25Z

this is unfortunate

benjamingr · 2023-09-25T13:18:53Z

@KhafraDev please do open an issue and express any concerns you have about versioning or breakage some of us may not be getting.

KhafraDev · 2023-09-25T15:21:01Z

My concerns are posted after this comment, I unfortunately don't have much time this week to write up a more detailed comment.

PR-URL: #45684 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Notable changes: doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * promote fetch/webstreams from experimental to stable (Steven) #45684 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 PR-URL: TODO

Notable changes: doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * promote fetch/webstreams from experimental to stable (Steven) #45684 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 PR-URL: #49917

ruyadorno · 2023-09-28T14:01:54Z

@KhafraDev I'll skip this commit in the upcoming v20.x release to give the group of people involved here more time to find a consensus. If the consensus is to move forward anyone can just remove the dont-land label and it should be picked up in the next release otherwise there's still time to revert it on main before it ships in a release.

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) nodejs#45684 esm: * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) nodejs#49144 fs: * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) nodejs#47653 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830 stream: * optimize Writable (Robert Nagy) nodejs#50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) nodejs#47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950 Semver-Major Commits: * (SEMVER-MAJOR) bump supported macOS and Xcode versions (Michaël Zasso) nodejs#49164 * (SEMVER-MAJOR) do not overwrite _writableState.defaultEncoding (Tobias Nießen) nodejs#49140 * (SEMVER-MAJOR) update llhttp to 9.1.2 (Paolo Insogna) nodejs#48981 * (SEMVER-MAJOR) validate options of `on` and `once` (Deokjin Kim) nodejs#46018 * (SEMVER-MAJOR) adjust `position` validation in reading methods (Livia Medeiros) nodejs#42835 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) nodejs#47653 * (SEMVER-MAJOR) mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) nodejs#47497 * (SEMVER-MAJOR) remove aix directory case for package reader (Yagiz Nizipli) nodejs#48605 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) nodejs#47769 * (SEMVER-MAJOR) runtime deprecate punycode (Yagiz Nizipli) nodejs#47202 * (SEMVER-MAJOR) harmonize error code between ESM and CJS (Antoine du Hamel) nodejs#48606 * (SEMVER-MAJOR) do not treat `server.maxConnections=0` as `Infinity` (ignoramous) nodejs#48276 * (SEMVER-MAJOR) only defer _final call when connecting (Jason Zhang) nodejs#47385 * (SEMVER-MAJOR) rename internal NAPI_VERSION definition (Chengzhong Wu) nodejs#48501 * (SEMVER-MAJOR) throw DOMException on cloning non-serializable objects (Chengzhong Wu) nodejs#47839 * (SEMVER-MAJOR) throw DataCloneError on transfering untransferable objects (Chengzhong Wu) nodejs#47604 * (SEMVER-MAJOR) use private properties for strategies (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) use private properties for encoding (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) use private properties for compression (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) disallow array in `run` options (Raz Luvaton) nodejs#49935 * (SEMVER-MAJOR) support passing globs (Moshe Atlow) nodejs#47653 * (SEMVER-MAJOR) use `validateNumber` for `options.minDHSize` (Deokjin Kim) nodejs#49973 * (SEMVER-MAJOR) use validateFunction for `options.checkServerIdentity` (Deokjin Kim) nodejs#49896 * (SEMVER-MAJOR) runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) nodejs#49609 * (SEMVER-MAJOR) freeze `dependencySpecifiers` array (Antoine du Hamel) nodejs#49720 PR-URL: nodejs#49870 Co-authored-by: Michaël Zasso <targos@protonmail.com>

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) #45684 esm: * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) #49144 fs: * add flush option to writeFile() functions (Colin Ihrig) #50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 stream: * optimize Writable (Robert Nagy) #50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 Semver-Major Commits: * (SEMVER-MAJOR) bump supported macOS and Xcode versions (Michaël Zasso) #49164 * (SEMVER-MAJOR) do not overwrite _writableState.defaultEncoding (Tobias Nießen) #49140 * (SEMVER-MAJOR) update llhttp to 9.1.2 (Paolo Insogna) #48981 * (SEMVER-MAJOR) validate options of `on` and `once` (Deokjin Kim) #46018 * (SEMVER-MAJOR) adjust `position` validation in reading methods (Livia Medeiros) #42835 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 * (SEMVER-MAJOR) mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) #47497 * (SEMVER-MAJOR) remove aix directory case for package reader (Yagiz Nizipli) #48605 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 * (SEMVER-MAJOR) runtime deprecate punycode (Yagiz Nizipli) #47202 * (SEMVER-MAJOR) harmonize error code between ESM and CJS (Antoine du Hamel) #48606 * (SEMVER-MAJOR) do not treat `server.maxConnections=0` as `Infinity` (ignoramous) #48276 * (SEMVER-MAJOR) only defer _final call when connecting (Jason Zhang) #47385 * (SEMVER-MAJOR) rename internal NAPI_VERSION definition (Chengzhong Wu) #48501 * (SEMVER-MAJOR) throw DOMException on cloning non-serializable objects (Chengzhong Wu) #47839 * (SEMVER-MAJOR) throw DataCloneError on transfering untransferable objects (Chengzhong Wu) #47604 * (SEMVER-MAJOR) use private properties for strategies (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for encoding (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for compression (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) disallow array in `run` options (Raz Luvaton) #49935 * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 * (SEMVER-MAJOR) use `validateNumber` for `options.minDHSize` (Deokjin Kim) #49973 * (SEMVER-MAJOR) use validateFunction for `options.checkServerIdentity` (Deokjin Kim) #49896 * (SEMVER-MAJOR) runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) #49609 * (SEMVER-MAJOR) freeze `dependencySpecifiers` array (Antoine du Hamel) #49720 PR-URL: #49870 Co-authored-by: Michaël Zasso <targos@protonmail.com>

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) #45684 esm: * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) #49144 fs: * add flush option to writeFile() functions (Colin Ihrig) #50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 stream: * optimize Writable (Robert Nagy) #50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 Semver-Major Commits: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #49639 * (SEMVER-MAJOR) drop support for Visual Studio 2019 (Michaël Zasso) #49051 * (SEMVER-MAJOR) bump supported macOS and Xcode versions (Michaël Zasso) #49164 * (SEMVER-MAJOR) do not overwrite _writableState.defaultEncoding (Tobias Nießen) #49140 * (SEMVER-MAJOR) bump minimum ICU version to 73 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 8ec2651fbdd8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 89b3702c92b0 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick de9a5de2274f (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick b5b5d6c31bb0 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 93b1a74cbc9b (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 1a3ecc2483b2 (Michaël Zasso) #49639 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #49639 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #49639 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #49639 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #49639 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 to 11.8.172.13 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update llhttp to 9.1.2 (Paolo Insogna) #48981 * (SEMVER-MAJOR) validate options of `on` and `once` (Deokjin Kim) #46018 * (SEMVER-MAJOR) adjust `position` validation in reading methods (Livia Medeiros) #42835 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 * (SEMVER-MAJOR) update usage of always on Atomics API (Michaël Zasso) #49639 * (SEMVER-MAJOR) mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) #47497 * (SEMVER-MAJOR) remove aix directory case for package reader (Yagiz Nizipli) #48605 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 * (SEMVER-MAJOR) runtime deprecate punycode (Yagiz Nizipli) #47202 * (SEMVER-MAJOR) harmonize error code between ESM and CJS (Antoine du Hamel) #48606 * (SEMVER-MAJOR) do not treat `server.maxConnections=0` as `Infinity` (ignoramous) #48276 * (SEMVER-MAJOR) only defer _final call when connecting (Jason Zhang) #47385 * (SEMVER-MAJOR) rename internal NAPI_VERSION definition (Chengzhong Wu) #48501 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 120 (Michaël Zasso) #49639 * (SEMVER-MAJOR) throw DOMException on cloning non-serializable objects (Chengzhong Wu) #47839 * (SEMVER-MAJOR) throw DataCloneError on transfering untransferable objects (Chengzhong Wu) #47604 * (SEMVER-MAJOR) use private properties for strategies (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for encoding (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for compression (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) skip v8-updates/test-linux-perf (Michaël Zasso) #49639 * (SEMVER-MAJOR) skip test-tick-processor-arguments on SmartOS (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt REPL test to V8 changes (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt test-fs-write to V8 internal changes (Michaël Zasso) #49639 * (SEMVER-MAJOR) update flag to disable SharedArrayBuffer (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt debugger tests to V8 11.4 (Philip Pfaffe) #49639 * (SEMVER-MAJOR) disallow array in `run` options (Raz Luvaton) #49935 * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 * (SEMVER-MAJOR) use `validateNumber` for `options.minDHSize` (Deokjin Kim) #49973 * (SEMVER-MAJOR) use validateFunction for `options.checkServerIdentity` (Deokjin Kim) #49896 * (SEMVER-MAJOR) add new V8 headers to distribution (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.7 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.6 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.5 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.4 (Michaël Zasso) #49639 * (SEMVER-MAJOR) runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) #49609 * (SEMVER-MAJOR) freeze `dependencySpecifiers` array (Antoine du Hamel) #49720 PR-URL: #49870 Co-authored-by: Michaël Zasso <targos@protonmail.com>

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) #45684 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) #49144 fs: * add flush option to writeFile() functions (Colin Ihrig) #50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 http: * (SEMVER-MAJOR) reduce parts in chunked response when corking (Robert Nagy) #50167 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 stream: * optimize Writable (Robert Nagy) #50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 Semver-Major Commits: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #49639 * (SEMVER-MAJOR) drop support for Visual Studio 2019 (Michaël Zasso) #49051 * (SEMVER-MAJOR) bump supported macOS and Xcode versions (Michaël Zasso) #49164 * (SEMVER-MAJOR) do not overwrite _writableState.defaultEncoding (Tobias Nießen) #49140 * (SEMVER-MAJOR) bump minimum ICU version to 73 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 8ec2651fbdd8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 89b3702c92b0 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick de9a5de2274f (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick b5b5d6c31bb0 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 93b1a74cbc9b (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 1a3ecc2483b2 (Michaël Zasso) #49639 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #49639 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #49639 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #49639 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #49639 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 to 11.8.172.13 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update llhttp to 9.1.2 (Paolo Insogna) #48981 * (SEMVER-MAJOR) validate options of `on` and `once` (Deokjin Kim) #46018 * (SEMVER-MAJOR) adjust `position` validation in reading methods (Livia Medeiros) #42835 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 * (SEMVER-MAJOR) reduce parts in chunked response when corking (Robert Nagy) #50167 * (SEMVER-MAJOR) update usage of always on Atomics API (Michaël Zasso) #49639 * (SEMVER-MAJOR) mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) #47497 * (SEMVER-MAJOR) remove aix directory case for package reader (Yagiz Nizipli) #48605 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 * (SEMVER-MAJOR) runtime deprecate punycode (Yagiz Nizipli) #47202 * (SEMVER-MAJOR) harmonize error code between ESM and CJS (Antoine du Hamel) #48606 * (SEMVER-MAJOR) do not treat `server.maxConnections=0` as `Infinity` (ignoramous) #48276 * (SEMVER-MAJOR) only defer _final call when connecting (Jason Zhang) #47385 * (SEMVER-MAJOR) rename internal NAPI_VERSION definition (Chengzhong Wu) #48501 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 120 (Michaël Zasso) #49639 * (SEMVER-MAJOR) throw DOMException on cloning non-serializable objects (Chengzhong Wu) #47839 * (SEMVER-MAJOR) throw DataCloneError on transfering untransferable objects (Chengzhong Wu) #47604 * (SEMVER-MAJOR) use private properties for strategies (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for encoding (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for compression (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) skip v8-updates/test-linux-perf (Michaël Zasso) #49639 * (SEMVER-MAJOR) skip test-tick-processor-arguments on SmartOS (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt REPL test to V8 changes (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt test-fs-write to V8 internal changes (Michaël Zasso) #49639 * (SEMVER-MAJOR) update flag to disable SharedArrayBuffer (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt debugger tests to V8 11.4 (Philip Pfaffe) #49639 * (SEMVER-MAJOR) disallow array in `run` options (Raz Luvaton) #49935 * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 * (SEMVER-MAJOR) use `validateNumber` for `options.minDHSize` (Deokjin Kim) #49973 * (SEMVER-MAJOR) use validateFunction for `options.checkServerIdentity` (Deokjin Kim) #49896 * (SEMVER-MAJOR) add new V8 headers to distribution (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.7 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.6 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.5 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.4 (Michaël Zasso) #49639 * (SEMVER-MAJOR) runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) #49609 * (SEMVER-MAJOR) freeze `dependencySpecifiers` array (Antoine du Hamel) #49720 PR-URL: #49870 Co-authored-by: Michaël Zasso <targos@protonmail.com>

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) #45684 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) #49144 fs: * add flush option to writeFile() functions (Colin Ihrig) #50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 http: * (SEMVER-MAJOR) reduce parts in chunked response when corking (Robert Nagy) #50167 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 stream: * optimize Writable (Robert Nagy) #50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 Semver-Major Commits: * (SEMVER-MAJOR) build: drop support for Visual Studio 2019 (Michaël Zasso) #49051 * (SEMVER-MAJOR) build: bump supported macOS and Xcode versions (Michaël Zasso) #49164 * (SEMVER-MAJOR) crypto: do not overwrite \_writableState.defaultEncoding (Tobias Nießen) #49140 * (SEMVER-MAJOR) deps: bump minimum ICU version to 73 (Michaël Zasso) #49639 * (SEMVER-MAJOR) deps: update V8 to 11.8.172.13 (Michaël Zasso) #49639 * (SEMVER-MAJOR) deps: update llhttp to 9.1.2 (Paolo Insogna) #48981 * (SEMVER-MAJOR) events: validate options of `on` and `once` (Deokjin Kim) #46018 * (SEMVER-MAJOR) fs: adjust `position` validation in reading methods (Livia Medeiros) #42835 * (SEMVER-MAJOR) fs: add globSync implementation (Moshe Atlow) #47653 * (SEMVER-MAJOR) http: reduce parts in chunked response when corking (Robert Nagy) #50167 * (SEMVER-MAJOR) lib: mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) #47497 * (SEMVER-MAJOR) lib: remove aix directory case for package reader (Yagiz Nizipli) #48605 * (SEMVER-MAJOR) lib: add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 * (SEMVER-MAJOR) lib: runtime deprecate punycode (Yagiz Nizipli) #47202 * (SEMVER-MAJOR) module: harmonize error code between ESM and CJS (Antoine du Hamel) #48606 * (SEMVER-MAJOR) net: do not treat `server.maxConnections=0` as `Infinity` (ignoramous) #48276 * (SEMVER-MAJOR) net: only defer \_final call when connecting (Jason Zhang) #47385 * (SEMVER-MAJOR) node-api: rename internal NAPI\_VERSION definition (Chengzhong Wu) #48501 * (SEMVER-MAJOR) src: update NODE\_MODULE\_VERSION to 120 (Michaël Zasso) #49639 * (SEMVER-MAJOR) src: throw DOMException on cloning non-serializable objects (Chengzhong Wu) #47839 * (SEMVER-MAJOR) src: throw DataCloneError on transfering untransferable objects (Chengzhong Wu) #47604 * (SEMVER-MAJOR) stream: use private properties for strategies (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) stream: use private properties for encoding (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) stream: use private properties for compression (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) test\_runner: disallow array in `run` options (Raz Luvaton) #49935 * (SEMVER-MAJOR) test\_runner: support passing globs (Moshe Atlow) #47653 * (SEMVER-MAJOR) tls: use `validateNumber` for `options.minDHSize` (Deokjin Kim) #49973 * (SEMVER-MAJOR) tls: use validateFunction for `options.checkServerIdentity` (Deokjin Kim) #49896 * (SEMVER-MAJOR) util: runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) #49609 * (SEMVER-MAJOR) vm: freeze `dependencySpecifiers` array (Antoine du Hamel) #49720 PR-URL: #49870 Co-authored-by: Michaël Zasso <targos@protonmail.com>

PR-URL: nodejs#45684 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) nodejs#45684 esm: * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) nodejs#49144 fs: * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) nodejs#47653 http: * (SEMVER-MAJOR) reduce parts in chunked response when corking (Robert Nagy) nodejs#50167 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) nodejs#47769 stream: * optimize Writable (Robert Nagy) nodejs#50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) nodejs#47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950 Semver-Major Commits: * (SEMVER-MAJOR) build: drop support for Visual Studio 2019 (Michaël Zasso) nodejs#49051 * (SEMVER-MAJOR) build: bump supported macOS and Xcode versions (Michaël Zasso) nodejs#49164 * (SEMVER-MAJOR) crypto: do not overwrite \_writableState.defaultEncoding (Tobias Nießen) nodejs#49140 * (SEMVER-MAJOR) deps: bump minimum ICU version to 73 (Michaël Zasso) nodejs#49639 * (SEMVER-MAJOR) deps: update V8 to 11.8.172.13 (Michaël Zasso) nodejs#49639 * (SEMVER-MAJOR) deps: update llhttp to 9.1.2 (Paolo Insogna) nodejs#48981 * (SEMVER-MAJOR) events: validate options of `on` and `once` (Deokjin Kim) nodejs#46018 * (SEMVER-MAJOR) fs: adjust `position` validation in reading methods (Livia Medeiros) nodejs#42835 * (SEMVER-MAJOR) fs: add globSync implementation (Moshe Atlow) nodejs#47653 * (SEMVER-MAJOR) http: reduce parts in chunked response when corking (Robert Nagy) nodejs#50167 * (SEMVER-MAJOR) lib: mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) nodejs#47497 * (SEMVER-MAJOR) lib: remove aix directory case for package reader (Yagiz Nizipli) nodejs#48605 * (SEMVER-MAJOR) lib: add `navigator.hardwareConcurrency` (Yagiz Nizipli) nodejs#47769 * (SEMVER-MAJOR) lib: runtime deprecate punycode (Yagiz Nizipli) nodejs#47202 * (SEMVER-MAJOR) module: harmonize error code between ESM and CJS (Antoine du Hamel) nodejs#48606 * (SEMVER-MAJOR) net: do not treat `server.maxConnections=0` as `Infinity` (ignoramous) nodejs#48276 * (SEMVER-MAJOR) net: only defer \_final call when connecting (Jason Zhang) nodejs#47385 * (SEMVER-MAJOR) node-api: rename internal NAPI\_VERSION definition (Chengzhong Wu) nodejs#48501 * (SEMVER-MAJOR) src: update NODE\_MODULE\_VERSION to 120 (Michaël Zasso) nodejs#49639 * (SEMVER-MAJOR) src: throw DOMException on cloning non-serializable objects (Chengzhong Wu) nodejs#47839 * (SEMVER-MAJOR) src: throw DataCloneError on transfering untransferable objects (Chengzhong Wu) nodejs#47604 * (SEMVER-MAJOR) stream: use private properties for strategies (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) stream: use private properties for encoding (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) stream: use private properties for compression (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) test\_runner: disallow array in `run` options (Raz Luvaton) nodejs#49935 * (SEMVER-MAJOR) test\_runner: support passing globs (Moshe Atlow) nodejs#47653 * (SEMVER-MAJOR) tls: use `validateNumber` for `options.minDHSize` (Deokjin Kim) nodejs#49973 * (SEMVER-MAJOR) tls: use validateFunction for `options.checkServerIdentity` (Deokjin Kim) nodejs#49896 * (SEMVER-MAJOR) util: runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) nodejs#49609 * (SEMVER-MAJOR) vm: freeze `dependencySpecifiers` array (Antoine du Hamel) nodejs#49720 PR-URL: nodejs#49870 Co-authored-by: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 30, 2022

styfle mentioned this pull request Nov 30, 2022

[v18.x] lib: drop fetch experimental warning #45628

Closed

doc: change fetch from experimental to stable

bddf8ce

This PR implements documentation changes related to nodejs#45287

styfle force-pushed the fix-docs-remove-experimental branch from 0f0df86 to bddf8ce Compare November 30, 2022 13:57

VoltrexKeyva reviewed Nov 30, 2022

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

doc: add "exposition"

86cf08e

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

styfle requested a review from VoltrexKeyva December 1, 2022 00:07

VoltrexKeyva approved these changes Dec 1, 2022

View reviewed changes

aduh95 requested changes Dec 1, 2022

View reviewed changes

ronag approved these changes Dec 1, 2022

View reviewed changes

mcollina added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Dec 1, 2022

mhdawson mentioned this pull request Dec 5, 2022

Node.js Technical Steering Committee (TSC) Meeting 2022-12-07 nodejs/TSC#1317

Closed

This was referenced Dec 14, 2022

Node.js Technical Steering Committee (TSC) Meeting 2022-12-14 nodejs/TSC#1319

Closed

Node.js Technical Steering Committee (TSC) Meeting 2022-12-21 nodejs/TSC#1321

Closed

jasnell approved these changes Dec 19, 2022

View reviewed changes

Ethan-Arrowood approved these changes Dec 19, 2022

View reviewed changes

styfle requested a review from aduh95 December 19, 2022 21:27

mcollina previously requested changes Dec 20, 2022

View reviewed changes

mhdawson mentioned this pull request Jan 2, 2023

Node.js Technical Steering Committee (TSC) Meeting 2023-01-04 nodejs/TSC#1323

Closed

mhdawson removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Jan 4, 2023

KhafraDev mentioned this pull request Jan 5, 2023

feat: add cookie parsing ability nodejs/undici#1848

Merged

thernstig mentioned this pull request Jan 18, 2023

node@18.x.x version not fetch global api ? DefinitelyTyped/DefinitelyTyped#60924

Closed

aduh95 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 24, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 24, 2023

aduh95 merged commit 740ca54 into nodejs:main Sep 24, 2023

styfle deleted the fix-docs-remove-experimental branch September 25, 2023 14:55

matamatanot mentioned this pull request Sep 26, 2023

"Can't resolve encoding" warning in the console when used with Next JS 13.4 firebase/firebase-js-sdk#7280

Closed

ruyadorno mentioned this pull request Sep 28, 2023

v20.7.1 proposal #49917

Closed

ruyadorno added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 28, 2023

cristiand391 mentioned this pull request Oct 2, 2023

request module (jsforce dependency) is deprecated jsforce/jsforce#999

Closed

RafaelGSS mentioned this pull request Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

ejizba mentioned this pull request Oct 9, 2024

Remove undici dependency Azure/azure-functions-nodejs-library#305

Closed

Uh oh!

Conversation

styfle commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Dec 1, 2022

Uh oh!

targos commented Dec 1, 2022

Uh oh!

aduh95 commented Dec 19, 2022

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Jan 4, 2023

Uh oh!

KhafraDev commented Jan 4, 2023

Uh oh!

mcollina commented Jan 5, 2023

Uh oh!

piranna commented Jan 18, 2023

Uh oh!

KhafraDev commented Jan 18, 2023

Uh oh!

nodejs-github-bot commented Sep 24, 2023

Uh oh!

aduh95 commented Sep 24, 2023

Uh oh!

KhafraDev commented Sep 24, 2023

Uh oh!

benjamingr commented Sep 25, 2023

Uh oh!

KhafraDev commented Sep 25, 2023

Uh oh!

ruyadorno commented Sep 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

styfle commented Nov 30, 2022 •

edited

Loading