Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add link to doc with social processes #45584

Closed
wants to merge 8 commits into from

Conversation

mhdawson
Copy link
Member

Signed-off-by: Michael Dawson mdawson@devrus.com

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 22, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@@ -0,0 +1,6 @@
# Interacting with social
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Interacting with social" is jargony. Most people don't translate "social" to "social media" much less "the social media team".

How about "Requesting social media posts" or something like that? (Same for the name of the file.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, even better might be "Suggesting social media posts". @nodejs/social

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to change the any to any of those, or whatever based on any more feedback fom social team.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Requesting social media posts or amplification" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "amplification" is still pretty jargony and makes it needlessly verbose, but I wouldn't block that. It's certainly more clear, I think, than "Interacting with social".

Copy link
Member Author

@mhdawson mhdawson Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the link that we got from the Foundation staff was Node.js Social Amplication Request Guidelines I could just use that minus the Node.js part which I think would be redundant.

Copy link
Member Author

@mhdawson mhdawson Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be specific social-amplification-request-guidelines.md

Copy link
Member

@Trott Trott Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the link that we got from the Foundation staff was Node.js Social Amplication Request Guidelines I could just use that minus the Node.js part which I think would be redundant.

You could, and I'm not going to block on this, but it's jargon. Jargon is OK for an internal document or a draft, but if we're publishing it widely, "social amplification" is a term likely to be unfamiliar to most readers. We should use terms that most people are likely to understand and that they might be searching for so they can find the right doc. If I were trying to find out how to get the nodejs Twitter account to retweet something, I might search for "social media" or "Twitter" or "posts" or "tweet", but I would be unlikely to search for "amplification" or "interacting with social".

I'm not going to block on this, though, because having a link to the process is vastly better than not having a link to the process, even if the document containing the link has a title that I think could be improved. So better that this land than I get things hung up on a word or two in the title.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott , I really don't feel strong about it just thought leveraging language that the social team had used could make sense. I'll change to suggesting-social-media-posts.md

mhdawson and others added 3 commits November 23, 2022 15:37
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
mhdawson and others added 2 commits November 24, 2022 09:25
Co-authored-by: Rich Trott <rtrott@gmail.com>
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member Author

@Trott updated.

mhdawson added a commit that referenced this pull request Nov 25, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@mhdawson
Copy link
Member Author

Landed in 9bc00fd

@mhdawson mhdawson closed this Nov 25, 2022
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Nov 30, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#45584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Dec 12, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants