Merged
Conversation
github-actions
bot
added
the
meta
Collaborator
|
Review requested:
|
Trott
approved these changes
Nov 21, 2022
Contributor
Author
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
legendecas
reviewed
Nov 21, 2022
| """ | ||
| zlib.h -- interface of the 'zlib' general purpose compression library | ||
| version 1.2.11, January 15th, 2017 | ||
| version 1.2.13, October 13th, 2022 |
Member
There was a problem hiding this comment.
The zlib on the main branch is still v1.2.12: b6c108f
Member
There was a problem hiding this comment.
deps/zlib/zlib.h says 1.2.13. 🤷 deps/zlib/LICENSE says 1.2.12 though. 🤔
Member
There was a problem hiding this comment.
https://chromium.googlesource.com/chromium/src/third_party/zlib indicates that 8bbd6c31 is 1.2.13, so I think this commit is correct and the zlib LICENSE file didn't get updated for the release. So I think we're good.
gireeshpunathil
approved these changes
Nov 21, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in abadaca |
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Nov 23, 2022
PR-URL: nodejs#45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License is likely out of date. This is an automatically generated PR by the
license-builder.ymlGitHub Action, which runslicense-builder.shand submits a new PR or updates an existing PR.