Skip to content

benchmark: add v8 serialize benchmark#45476

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
anonrig:benchmark/v8-serialize
Nov 21, 2022
Merged

benchmark: add v8 serialize benchmark#45476
nodejs-github-bot merged 1 commit intonodejs:mainfrom
anonrig:benchmark/v8-serialize

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Nov 15, 2022

@anonrig anonrig force-pushed the benchmark/v8-serialize branch from 5b90a18 to 9243af9 Compare November 15, 2022 16:54
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Nov 15, 2022
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 15, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47954/

tniessen
tniessen reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess since the object is always the same, this is only supposed to benchmark the call overhead and not the serialization itself?

@anonrig anonrig force-pushed the benchmark/v8-serialize branch from 9243af9 to cdb5079 Compare November 17, 2022 13:55
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@anonrig anonrig force-pushed the benchmark/v8-serialize branch from cdb5079 to 313e3e8 Compare November 17, 2022 14:00
@anonrig anonrig requested a review from jasnell November 17, 2022 14:00
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47985/

@anonrig anonrig requested a review from tniessen November 18, 2022 23:21
@anonrig
Copy link
Member Author

anonrig commented Nov 19, 2022

@tniessen @jasnell Can you re-review?

@aduh95
Copy link
Contributor

aduh95 commented Nov 20, 2022 •
edited
Loading

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1226/ (it failed)
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1227/

It was successful 
                                     confidence improvement accuracy (*)   (**)  (***)
v8/serialize.js n=1000000 len=16384                  0.07 %       ±1.00% ±1.33% ±1.74%
v8/serialize.js n=1000000 len=256                   -2.71 %       ±4.44% ±5.91% ±7.69%
v8/serialize.js n=1000000 len=524288                -0.38 %       ±1.14% ±1.52% ±1.97%

@anonrig anonrig requested a review from aduh95 November 21, 2022 13:49
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit 09d083f into nodejs:main Nov 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2022

Landed in 09d083f

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@anonrig @ruyadorno
benchmark: add v8 serialize benchmark
f08f6a6 
PR-URL: #45476
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@anonrig @marco-ippolito
benchmark: add v8 serialize benchmark
630ff65 
PR-URL: nodejs#45476
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig @danielleadams
benchmark: add v8 serialize benchmark
09005c3 
PR-URL: #45476
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig @danielleadams
benchmark: add v8 serialize benchmark
6756441 
PR-URL: #45476
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig @danielleadams
benchmark: add v8 serialize benchmark
a142162 
PR-URL: #45476
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@anonrig @danielleadams
benchmark: add v8 serialize benchmark
6330257 
PR-URL: #45476
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@anonrig @danielleadams
benchmark: add v8 serialize benchmark
43f27b5 
PR-URL: #45476
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig @nodejs-github-bot @aduh95 @jasnell @tniessen