Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 10.7.193.22 #45460

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

targos
Copy link
Member

@targos targos commented Nov 14, 2022

@targos targos added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Nov 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 14, 2022
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@anonrig
Copy link
Member

anonrig commented Nov 15, 2022

@targos What is your timeline/thoughts for upgrading v8 11?

@Trott
Copy link
Member

Trott commented Nov 15, 2022

You'll need to rebase against the main branch to pick up the fix for the lint issue.

@targos
Copy link
Member Author

targos commented Nov 15, 2022

Rebased

@targos
Copy link
Member Author

targos commented Nov 15, 2022

@anonrig Whenever it's ready. Note that there's nothing special to expect with V8 11.0 compared to other versions. V8 version numbers don't follow semver, they follow the Chromium schedule.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen
Copy link
Member

@targos What is your timeline/thoughts for upgrading v8 11?

You can try latest v8 bundled in node in https://github.com/nodejs/node-v8/tree/canary.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8f9dc27 into nodejs:main Nov 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8f9dc27

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
Refs: v8/v8@10.7.193.20...10.7.193.22
PR-URL: #45460
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants