Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watch mode: use recursive fs.watch #45271

Closed
wants to merge 1 commit into from
Closed

watch mode: use recursive fs.watch #45271

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Nov 1, 2022

follow up for #45098
adapting recursive file watching into watch mode

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Nov 1, 2022
@MoLow
Copy link
Member Author

MoLow commented Nov 1, 2022 •
edited
Loading

CC @anonrig

anonrig
anonrig approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2022
@anonrig
Copy link
Member

anonrig commented Nov 1, 2022

CC @nodejs/fs

@anonrig anonrig added the fs Issues and PRs related to the fs subsystem / file system. label Nov 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47622/

@bricss bricss mentioned this pull request Nov 2, 2022
Merged
@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch from b5f62bb to 5dbf508 Compare November 3, 2022 10:46
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Nov 3, 2022
@MoLow
Copy link
Member Author

MoLow commented Nov 5, 2022

@anonrig do you have any idea why this might crash the CI?

anonrig
anonrig requested changes Nov 5, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly think that due to the async nature of fs.watch is causing the errors to fail. Please add a timeout after listening

@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch from 5dbf508 to 75f4a97 Compare November 5, 2022 22:04
@MoLow
Copy link
Member Author

MoLow commented Nov 5, 2022

@anonrig I have implemented your suggestions, but it is not just a test failure - the build seems to crash

@MoLow MoLow mentioned this pull request Nov 6, 2022
Merged
@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch from 75f4a97 to 1699f00 Compare November 6, 2022 21:38
@anonrig
Copy link
Member

anonrig commented Nov 7, 2022

I think you need to skip the tests for only AIX and IBMi.

@MoLow
Copy link
Member Author

MoLow commented Nov 7, 2022

I think you need to skip the tests for only AIX and IBMi.

I am just trying to figure out why the build is crashing

@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch 2 times, most recently from c0fefbe to fa63c9b Compare November 9, 2022 14:42
@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch from 170cade to 2d6f225 Compare November 12, 2022 19:27
@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch from 2d6f225 to 7b63ee7 Compare November 13, 2022 06:36
@MoLow
Copy link
Member Author

MoLow commented Nov 13, 2022

will handle this after #45214 since they conflict as well

@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch from 6812665 to dc77925 Compare November 13, 2022 21:41
anonrig
anonrig requested changes Nov 13, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the issue with lib/internal/fs/recursive_watch.js should be committed separately in a different pull request. Other than that, I've added some comments. Thank you for your contribution!

@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch from dc77925 to 93532f3 Compare November 17, 2022 20:20
@MoLow MoLow force-pushed the watch-mode-recursive-follow-up branch from 93532f3 to 03e801d Compare November 27, 2022 22:12
@MoLow MoLow mentioned this pull request May 8, 2024
Open
@MoLow MoLow closed this May 24, 2024
@MoLow MoLow deleted the watch-mode-recursive-follow-up branch May 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig requested changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoLow @anonrig @nodejs-github-bot