test: fix flaky test-http-agent-keepalive #4524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove timeout delay causing flakiness on SmartOS. Fixes: nodejs#4492
Trott
added
http
|
nice nice, this reminds me of webdev where you throw random delays at stuff to fix them! lgtm, great work as usual @Trott. |
|
CI: https://ci.nodejs.org/job/node-test-commit/1616/ Stress test without this fix: 14 failures in 9999 runs Stress test with this fix: 0 failures in 2139 runs so far and counting... |
|
Make that |
|
LGTM |
|
Landed in 6ea8b01 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Remove timeout delay causing flakiness on SmartOS. Fixes: nodejs#4492 PR-URL: nodejs#4524 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Remove timeout delay causing flakiness on SmartOS. Fixes: nodejs#4492 PR-URL: nodejs#4524 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove timeout delay causing flakiness on SmartOS.
The key change is the setTimeout->setImmediate in line 21. The rest of the changes are just opportunistic updates.
Fixes: #4492