test: make test-eventemitter-asyncresource.js shorter
#45146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
juanarbol
force-pushed
the
juan/refactor-events-test
branch
from
9dd5cc2 to
b95e139
Compare
lpinca
approved these changes
Oct 24, 2022
Flarna
reviewed
Oct 25, 2022
Flarna
approved these changes
Oct 25, 2022
jasnell
approved these changes
Oct 26, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol
force-pushed
the
juan/refactor-events-test
branch
from
b95e139 to
c27bb19
Compare
Flarna
approved these changes
Oct 28, 2022
This was referenced Oct 29, 2022
19 tasks
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 74d2147 |
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: nodejs#45146 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45146 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45146 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45146 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45146 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan José Arboleda soyjuanarbol@gmail.com