-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: inherit JOBS from environment #4495
test: inherit JOBS from environment #4495
Conversation
/R=the never sleeping @Trott or perhaps @nodejs/build. |
CI with |
LGTM |
..and here we are; the first all-green on ..as a side note; we've now reduced the test time on smartos by 30% (~15m -> ~10m). Figuring out the rest lives in nodejs/build#293 |
Unrelated fail on first CI run (which shouldn't be affected by this) and a few – other – fails on the |
In some virtualized environments the amount of available resources are misleading; for instance `multiprocessing.cpu_count()` on our current 4-core smartos vm's returns `48`. This is not a bug, merely how the vm host provides information about available hardware. Avoid running into issues by overriding `cpu_count()` with `JOBS`. PR-URL: nodejs#4495 Reviewed-By: Brian White <mscdex@mscdex.net>
f470abe
to
1170b26
Compare
In some virtualized environments the amount of available resources are misleading; for instance `multiprocessing.cpu_count()` on our current 4-core smartos vm's returns `48`. This is not a bug, merely how the vm host provides information about available hardware. Avoid running into issues by overriding `cpu_count()` with `JOBS`. PR-URL: nodejs#4495 Reviewed-By: Brian White <mscdex@mscdex.net>
In some virtualized environments the amount of available resources are misleading; for instance `multiprocessing.cpu_count()` on our current 4-core smartos vm's returns `48`. This is not a bug, merely how the vm host provides information about available hardware. Avoid running into issues by overriding `cpu_count()` with `JOBS`. PR-URL: #4495 Reviewed-By: Brian White <mscdex@mscdex.net>
In some virtualized environments the amount of available resources are misleading; for instance `multiprocessing.cpu_count()` on our current 4-core smartos vm's returns `48`. This is not a bug, merely how the vm host provides information about available hardware. Avoid running into issues by overriding `cpu_count()` with `JOBS`. PR-URL: #4495 Reviewed-By: Brian White <mscdex@mscdex.net>
In some virtualized environments the amount of available resources are misleading; for instance `multiprocessing.cpu_count()` on our current 4-core smartos vm's returns `48`. This is not a bug, merely how the vm host provides information about available hardware. Avoid running into issues by overriding `cpu_count()` with `JOBS`. PR-URL: #4495 Reviewed-By: Brian White <mscdex@mscdex.net>
In some virtualized environments the amount of available resources are misleading; for instance `multiprocessing.cpu_count()` on our current 4-core smartos vm's returns `48`. This is not a bug, merely how the vm host provides information about available hardware. Avoid running into issues by overriding `cpu_count()` with `JOBS`. PR-URL: nodejs#4495 Reviewed-By: Brian White <mscdex@mscdex.net>
In some virtualized environments the amount of available resources are misleading; for instance
multiprocessing.cpu_count()
on our current 4-core smartos vm's returns48
. This is not a bug, merely how the vm host provides information about available hardware.Avoid running into issues by overriding
cpu_count()
withJOBS
.Refs #4494.