Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check --test is disallowed in NODE_OPTIONS #44846

Merged
merged 1 commit into from
Oct 7, 2022
Merged

test: check --test is disallowed in NODE_OPTIONS #44846

merged 1 commit into from
Oct 7, 2022

Conversation

cola119
Copy link
Member

@cola119 cola119 commented Oct 1, 2022

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 1, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46971/

@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2022
This was referenced Oct 3, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47104/

@cola119 cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot merged commit 2c57b94 into nodejs:main Oct 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 2c57b94

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@cola119 @danielleadams
test: check --test is disallowed in NODE_OPTIONS
a080608 
PR-URL: #44846
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@himself65 himself65 himself65 approved these changes

@daeyeon daeyeon daeyeon approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@bnb bnb bnb approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cola119 @nodejs-github-bot @jasnell @bnb @lpinca @cjihrig @daeyeon @himself65 @RaisinTen @panva