Skip to content

[v18.x backport] util: increase robustness with primordials #44797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v18.x backport] util: increase robustness with primordials #44797

wants to merge 1 commit into from

Conversation

@ljharb
Copy link
Member

@ljharb ljharb commented Sep 26, 2022

@ljharb ljharb requested a review from RafaelGSS September 26, 2022 16:24
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2022

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Sep 26, 2022
@ljharb ljharb changed the base branch from main to v18.x September 26, 2022 16:25
@ljharb ljharb mentioned this pull request Sep 26, 2022
Merged
@RafaelGSS RafaelGSS changed the base branch from v18.x to v18.x-staging September 26, 2022 16:36
@RafaelGSS RafaelGSS added the v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. label Sep 26, 2022
RafaelGSS
RafaelGSS approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2022
@RafaelGSS
Copy link
Member

RafaelGSS commented Sep 26, 2022

Could you please rebase on v18.x-staging? Just to make sure CI passes

@ljharb
Copy link
Member Author

ljharb commented Sep 26, 2022

Done!

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46825/

@ljharb
Copy link
Member Author

ljharb commented Sep 26, 2022 •
edited
Loading

Hmm, some of these failures don't seem related to this PR?

@RafaelGSS
Copy link
Member

RafaelGSS commented Sep 26, 2022

Yeah, they don't. I'm still working on that on #44799. Once it's done I'll let you know so you can rebase again. Sorry for the incovenience.

@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Open
14 tasks
@RafaelGSS
Copy link
Member

RafaelGSS commented Sep 27, 2022

Once it's done I'll let you know so you can rebase again

It should be resolved. Could you please rebase?

@ljharb
Copy link
Member Author

ljharb commented Sep 27, 2022

done!

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46863/

This was referenced Sep 28, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Sep 30, 2022
Open
17 tasks
RafaelGSS
RafaelGSS approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS
Copy link
Member

RafaelGSS commented Sep 30, 2022

looks like CI wasn't triggered

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46961/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47058/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47062/

danielleadams pushed a commit that referenced this pull request Oct 4, 2022
@ljharb @danielleadams
util: increase robustness with primordials
576ccdf 
(backported from #41212)

Backport-PR-URL: #44797
PR-URL: #41212
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams
Copy link
Contributor

danielleadams commented Oct 4, 2022

Landed in 576ccdf

@ljharb ljharb deleted the backport-41212 branch October 4, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

+1 more reviewer

@danielleadams danielleadams danielleadams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ljharb @nodejs-github-bot @RafaelGSS @danielleadams