Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change promises to async/await in test-debugger-backtrace.js #44672

Closed
wants to merge 1 commit into from
Closed

test: change promises to async/await in test-debugger-backtrace.js #44672

wants to merge 1 commit into from

Conversation

zhangjuliet
Copy link
Contributor

Signed-off-by: Juliet Zhang julietzhang3@gmail.com

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
@tniessen
Copy link
Member

Hi @zhangjuliet and thank you for the contribution! The commit message linter is failing because your commit message exceeds the allowed length (see commit message guidelines).

You can fix this by running git commit --amend locally to edit the commit message, followed by git push --force-with-lease.

@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 16, 2022
@tniessen tniessen mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangjuliet @tniessen @nodejs-github-bot