Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.9.0 release proposal #44521

Merged
merged 94 commits into from
Sep 8, 2022
Merged

v18.9.0 release proposal #44521

merged 94 commits into from
Sep 8, 2022

Commits on Sep 5, 2022

  1. build: added NINJA env to customize ninja binary

    Fixes: #44286
    PR-URL: #44293
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jdx authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    30da2b4 View commit details
    Browse the repository at this point in the history
  2. tls: use OpenSSL constant for client random size

    Avoid magic numbers in the code and use an OpenSSL constant instead.
    
    PR-URL: #44305
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7039916 View commit details
    Browse the repository at this point in the history
  3. tls: remove SecureContext setFreeListLength

    This function was introduced in 2684c90
    as an internal helper function. The C++ implementation became a no-op in
    a57e2f2 when building against OpenSSL
    1.1.0 (instead of OpenSSL 1.0.2), and eventually became a no-op in all
    supported OpenSSL versions in 970ce14.
    Finally, eb20447 removed the only call
    site of setFreeListLength (which was already a no-op at that point).
    
    Refs: #1529
    Refs: #10859
    Refs: #19794
    Refs: #38116
    PR-URL: #44300
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1cdccbc View commit details
    Browse the repository at this point in the history
  4. src: make minor improvements to SecureBuffer

    Remove an unnecessary static_cast<char*>().
    
    Use OPENSSL_secure_zalloc() instead of OPENSSL_secure_malloc() +
    memset().
    
    Update the comment describing the function which predates support for
    OpenSSL's secure heap.
    
    PR-URL: #44302
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6857ee8 View commit details
    Browse the repository at this point in the history
  5. crypto: improve RSA-PSS digest error messages

    md and mgf1_md are internal variable names and should not appear in
    JS error messages. Also include the invalid digest name in the error
    message.
    
    PR-URL: #44307
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    28781a1 View commit details
    Browse the repository at this point in the history
  6. src: fix multiple format string bugs

    The THROW_ERR_* functions interpret the first argument as a printf-like
    format string, which is problematic when it contains unsanitized user
    input. This typically happens when a printf-like function is used to
    produce the error message, which is then passed to a THROW_ERR_*
    function, which again interprets the error message as a format string.
    
    Fix such occurrences by properly formatting error messages using static
    format strings only, and in a single step.
    
    PR-URL: #44314
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    768c9cb View commit details
    Browse the repository at this point in the history
  7. test: make tmpdir.js importable from esm

    PR-URL: #44322
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    GeoffreyBooth authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    11e9d6e View commit details
    Browse the repository at this point in the history
  8. doc: fix typo in test runner code examples

    PR-URL: #44351
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    MoLow authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8cc5556 View commit details
    Browse the repository at this point in the history
  9. doc: add daeyeon to collaborators

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44355
    Fixes: #44142
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    daeyeon authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4a0f750 View commit details
    Browse the repository at this point in the history
  10. doc: add history for net.createServer() options

    Fixes: #44298
    PR-URL: #44326
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    lpinca authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    65c1f40 View commit details
    Browse the repository at this point in the history
  11. vm: make ContextifyContext template context-independent

    Instead of creating an object template for every ContextifyContext,
    we now create one object template that can be reused by all
    contexts. The native pointer can be obtained through an embdder
    pointer field in the creation context of the receiver in the
    interceptors, because the interceptors are only meant to be invoked
    on the global object of the contextified contexts. This makes
    the ContextifyContext template context-independent and therefore
    snapshotable.
    
    PR-URL: #44252
    Refs: #44014
    Refs: #37476
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    bce827e View commit details
    Browse the repository at this point in the history
  12. vm: include vm context in the embedded snapshot

    Include a minimally initialized contextify context in the embedded
    snapshot. This paves the way for user-land vm context snapshots.
    
    PR-URL: #44252
    Refs: #44014
    Refs: #37476
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    736a04a View commit details
    Browse the repository at this point in the history
  13. vm: avoid unnecessary property getter interceptor calls

    Access to the global object from within a vm context is intercepted
    so it's slow, therefore we should try to avoid unnecessary access
    to it during the initialization of vm contexts.
    
    - Remove the Atomics.wake deletion as V8 now does not install it
      anymore.
    - Move the Intl.v8BreakIterator deletion into the snapshot.
    - Do not query the Object prototype if --disable-proto is not set.
    
    This should speed up the creation of vm contexts by about ~12%.
    
    PR-URL: #44252
    Refs: #44014
    Refs: #37476
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c4a45a9 View commit details
    Browse the repository at this point in the history
  14. deps: update undici to 5.9.1

    PR-URL: #44319
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    nodejs-github-bot authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    57da3db View commit details
    Browse the repository at this point in the history
  15. test_runner: support programmatically running --test

    PR-URL: #44241
    Fixes: #44023
    Fixes: #43675
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8175c65 View commit details
    Browse the repository at this point in the history
  16. debugger: decrease timeout used to wait for the port to be free

    By default, the debugger would query the specified inspector
    sever port to see if it's available before starting the server,
    and it would keep retrying until a timeout (previously 9999 ms)
    is reached. This timeout seems to be longer than necessary. This
    patch decreases the timeout to 3 seconds.
    
    PR-URL: #44359
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    joyeecheung authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b1eafe1 View commit details
    Browse the repository at this point in the history
  17. test: add OpenSSL 3.x providers test

    Add basic tests for providers when using OpenSSL 3.x.
    
    PR-URL: #44148
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    richardlau authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c65d7fb View commit details
    Browse the repository at this point in the history
  18. report: add queue info for udp

    PR-URL: #44345
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    theanarkh authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    df25900 View commit details
    Browse the repository at this point in the history
  19. report: expose report public native apis

    Allows APM vendors to generate a diagnostic report without calling into
    JavaScript. Like, from their own message channels interrupting the
    isolate and generating a report on demand.
    
    PR-URL: #44255
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    legendecas authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1f23c17 View commit details
    Browse the repository at this point in the history
  20. tty: fix TypeError when stream is closed

    Fixes: #41330
    PR-URL: #43803
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    aduh95 authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8b0a4af View commit details
    Browse the repository at this point in the history
  21. src: remove KeyObjectData::symmetric_key_len_

    symmetric_key_len_ is always equal to symmetric_key_.size(). Storing it
    separately is redundant and has no significant benefit.
    
    PR-URL: #44346
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    88d9566 View commit details
    Browse the repository at this point in the history
  22. test: remove duplicate test

    The test in `test/parallel/test-stream-writable-callback-twice.js` is
    duplicated in `test/parallel/test-stream-writable-write-cb-twice.js`.
    
    PR-URL: #44313
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    lpinca authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8e2dcaf View commit details
    Browse the repository at this point in the history
  23. node-api: cleanup redundant static modifiers

    Functions declared in anonymous namespaces are not necessarily to be
    marked as static.
    
    PR-URL: #44301
    Refs: #44141
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2563401 View commit details
    Browse the repository at this point in the history
  24. src: make minor improvements to EnabledDebugList

    Change the underlying type of DebugCategory to unsigned int so that it
    can be safely cast to an unsigned type without having to worry about
    negative values, removing the need for the DCHECK_GE statements.
    
    To fully benefit from type safety, remove DebugCategory::CATEGORY_COUNT
    and instead add a constexpr kDebugCategoryCount.
    
    Remove the second argument from EnabledDebugList::set_enabled() and
    EnabledDebugList::Parse() because it was always set to true.
    
    PR-URL: #44350
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3eb7918 View commit details
    Browse the repository at this point in the history
  25. doc: fix style of n-api.md

    PR-URL: #44377
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    theanarkh authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    ed52bd0 View commit details
    Browse the repository at this point in the history
  26. deps: upgrade llhttp to 6.0.9

    PR-URL: #44344
    Fixes: #43115
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    ShogunPanda authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1e451dc View commit details
    Browse the repository at this point in the history
  27. test: raise sleep times in child process tests

    sequential/test-child-process-execsync and
    parallel/test-child-process-spawnsync-timeout are both flaky
    on azure Windows machines, where it may take longer for Node.js
    to launch and receive output from child processes. These tests
    work by spawning a child processes that is supposed to sleep
    for a long time, but the option is configured so that Node.js
    would terminate them early when a shorter timeout is reached.
    Then the tests assert that the time taken for the whole thing
    is shorter than the specified sleep time (meaning the process
    don't actually get to sleep for that long). To make the tests
    less brittle on azure Windows, this patch raises the sleep
    times in those tests on Windows platform, so that the overhead
    can be taken into account there.
    
    PR-URL: #44375
    Refs: nodejs/build#3014
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    joyeecheung authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    e001aaf View commit details
    Browse the repository at this point in the history
  28. crypto: simplify control flow in HKDF

    Unify the implementation and perform the same OpenSSL calls regardless
    of whether the key and/or salt are empty. This simplifies the code and
    improves coverage.
    
    Refs: #44201
    PR-URL: #44272
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c3dbe18 View commit details
    Browse the repository at this point in the history
  29. inspector: prevent integer overflow in open()

    PR-URL: #44367
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2ed3b30 View commit details
    Browse the repository at this point in the history
  30. test: fix WPT runner result

    This doesn't include the other tests for the result when
    running a specific test in WPT.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44238
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    daeyeon authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3a5fdac View commit details
    Browse the repository at this point in the history
  31. deps: update icu tzdata to 2022b

    Following the documentation at:
    https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data
    
    Refs: nodejs/Release#773
    Refs: unicode-org/icu-data#29
    
    PR-URL: #44283
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Manizuca authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1b50ff2 View commit details
    Browse the repository at this point in the history
  32. src: simplify ECDH::GetCurves()

    There is no need to explicitly branch based on num_curves or on the
    return value of the second call to EC_get_builtin_curves. Remove
    unnecessary branches and replace the loop with a functional transform.
    
    PR-URL: #44309
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2be8aca View commit details
    Browse the repository at this point in the history
  33. lib: use safe Promise alternatives when available

    PR-URL: #43476
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    a86ef1b View commit details
    Browse the repository at this point in the history
  34. tools: refactor avoid-prototype-pollution lint rule

    The lint rule was not catching all occurences of unsafe primordials use,
    and was too strict on some methods.
    
    PR-URL: #43476
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b670954 View commit details
    Browse the repository at this point in the history
  35. src: use if constexpr where appropriate

    Doesn't change much but communicates to readers that these
    are compile-time conditionals.
    
    PR-URL: #44291
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7f16177 View commit details
    Browse the repository at this point in the history
  36. doc: fix release guide example consistency

    This changeset fixes two consistency issues in this single example that
    guides releasers on how to push the tag to the remote repo.
    
    The first issue is that the remote git reference is consistently
    referred as `upstream` elsewhere in the guide.
    
    The second issue being that the version example used in the rest of the
    guide should be a fictional `v1.2.3` as stated in the "How to create a
    release" guide notes:
    
    >  * Examples will use the fictional release version `1.2.3`.
    
    PR-URL: #44385
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ruyadorno authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    21437f7 View commit details
    Browse the repository at this point in the history
  37. stream: fix ReadableStreamReader.releaseLock()

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44292
    Refs: https://streams.spec.whatwg.org/#default-reader-release-lock
    Refs: https://streams.spec.whatwg.org/#byob-reader-release-lock
    Refs: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStreamDefaultReader/releaseLock
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    daeyeon authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    65134d6 View commit details
    Browse the repository at this point in the history
  38. tools: update eslint to 8.23.0

    PR-URL: #44419
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    96df993 View commit details
    Browse the repository at this point in the history
  39. doc: note on release guide to update main branch

    Added an extra command to make sure to remind me (and other releasers)
    to update the `main` branch _before_ cherry-picking the release commit
    to the branch.
    
    Adding this command will often avoid unnecessary extra-work in case
    there are mismatches between the local state of the main branch and
    remote.
    
    PR-URL: #44384
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    ruyadorno authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    cef30f9 View commit details
    Browse the repository at this point in the history
  40. lib: codify findSourceMap return value when not found

    Return `undefined` when no source map is found for the given filename on
    `findSourceMap`.
    
    PR-URL: #44397
    Fixes: #44391
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    legendecas authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b8f08e5 View commit details
    Browse the repository at this point in the history
  41. meta: update AUTHORS

    PR-URL: #44422
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c03f28b View commit details
    Browse the repository at this point in the history
  42. tools: update doc to unist-util-visit@4.1.1

    PR-URL: #44370
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    443730c View commit details
    Browse the repository at this point in the history
  43. deps: patch V8 to 10.2.154.15

    Refs: v8/v8@10.2.154.13...10.2.154.15
    PR-URL: #44294
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    targos authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    754d26a View commit details
    Browse the repository at this point in the history
  44. build: add --libdir flag to configure

    This will allow distribution packages to select an alternative
    location for the unofficial libnode.so. For example, on Fedora it
    will install into /usr/lib64 on 64-bit systems.
    
    Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
    PR-URL: #44361
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    sgallagher authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    e27e709 View commit details
    Browse the repository at this point in the history
  45. src: simplify and optimize GetOpenSSLVersion()

    The previous implementation was typically compiled to a fair amount of
    code even though all inputs are available at compile time.
    
    The fact that GetOpenSSLVersion() returns a std::string and used an
    uninitialized buffer with snprintf made it impossible to make
    GetOpenSSLVersion() a constexpr, and compilers would typically emit code
    to dynamically construct the resulting string.
    
    The simplified implementation usually boils down to a few mov
    instructions.
    
    (Ideally, this function could be a constexpr returning a
    std::string_view, but that does not have any advantage in the current
    design of node::Metadata::Versions which stores versions as
    std::string instances.)
    
    Also make the function static since it is not in an anonymous namespace
    and change the argument types and the return type of search() to
    types that are more appropriate, semantically. (The use of snprintf
    previously made this difficult.) Lastly, make the n argument of search()
    optional because the simplified implementation always sets it to 0
    except during recursive calls within search() itself.
    
    PR-URL: #44395
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    tniessen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    05fb650 View commit details
    Browse the repository at this point in the history
  46. tools: don't use f-strings in test.py

    PR #43954 introduced the use of f-strings to `test.py` making the script
    only work with python versions >= 3.6. Remove that use to make it
    compatible again with older python versions.
    
    PR-URL: #44407
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    santigimeno authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    78c6827 View commit details
    Browse the repository at this point in the history
  47. cluster: fix cluster rr distribute error

    PR-URL: #44202
    Reviewed-By: James M Snell <jasnell@gmail.com>
    theanarkh authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3c53548 View commit details
    Browse the repository at this point in the history
  48. src: restore context default IsCodeGenerationFromStringsAllowed value

    Context's default IsCodeGenerationFromStringsAllowed value can be
    changed by v8 flag `--disallow-code-generation-from-strings`. Restore
    the value at runtime when delegating the code generation validation to
    `node::ModifyCodeGenerationFromStrings`.
    
    The context's settings are serialized in the snapshot. Reset the setting
    values to its default values before the serialization so that it can be
    correctly re-initialized after deserialization at runtime.
    
    PR-URL: #44324
    Fixes: #44287
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    0f4e98b View commit details
    Browse the repository at this point in the history
  49. src: trace fs async api

    PR-URL: #44057
    Reviewed-By: James M Snell <jasnell@gmail.com>
    theanarkh authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    dc1c95e View commit details
    Browse the repository at this point in the history
  50. test: split report OOM tests

    On some machines the report OOM tests can take too long to complete,
    resulting in a timeout. This splits the test into several different
    smaller tests to reduce the flakiness of it.
    
    PR-URL: #44389
    Refs: nodejs/reliability#356
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    joyeecheung authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4ae1f49 View commit details
    Browse the repository at this point in the history
  51. doc,worker: document resourceLimits overrides

    If `--max-old-space-size` is passed on the command line, it takes
    precedence over `resourceLimits.maxOldSpaceSizeMb` passed to the worker
    thread. IMO this is a bug, but seems unlikely to change(?), so let's
    start by documenting it. See the attached issue for more details.
    
    Refs: #43991
    PR-URL: #43992
    Reviewed-By: James M Snell <jasnell@gmail.com>
    kvakil authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b660b74 View commit details
    Browse the repository at this point in the history
  52. os: add machine method

    PR-URL: #44416
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    theanarkh authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6714736 View commit details
    Browse the repository at this point in the history
  53. src: fix ssize_t error from nghttp2.h

    The "node_http2.h" include reordering enforced by clang-format broke
    Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX
    standard and it's not available on Windows, so the fix for this is to
    include "node.h" which typedefs it on Windows in
    https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220.
    
    Refs: electron/electron#35350 (comment)
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #44393
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    048e440 View commit details
    Browse the repository at this point in the history
  54. doc: mention cherry-pick edge-case on release

    PR-URL: #44408
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8e41dbb View commit details
    Browse the repository at this point in the history
  55. doc: fix spacing issue in --build-snapshot help text

    PR-URL: #44435
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    syohex authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3e6cde5 View commit details
    Browse the repository at this point in the history
  56. tools: fix typo in avoid-prototype-pollution lint rule

    PR-URL: #44446
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    aduh95 authored and RafaelGSS committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1e62bb1 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. src: make Endianness an enum class

    PR-URL: #44411
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and RafaelGSS committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    8db2e66 View commit details
    Browse the repository at this point in the history
  2. doc: apply scroll-margin-top to h2, h3 elements

    PR-URL: #44414
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    metonym authored and RafaelGSS committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    92046e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. src: fix uv_err_name memory leak

    PR-URL: #44421
    Refs: #44401
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    theanarkh authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4776b47 View commit details
    Browse the repository at this point in the history
  2. test: fix multiple incorrect mustNotCall() uses

    This does not fix occurrences in test/parallel/test-dns-* because those
    tests contain unrelated pre-existing bugs that would cause the tests to
    fail with this fix. This unrelated bug in those tests should be fixed
    separately before the use of mustNotCall() can be fixed in those files.
    
    PR-URL: #44022
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2dd88b8 View commit details
    Browse the repository at this point in the history
  3. crypto: use actual option name in error message

    oaep_label is the name of the C++ variable. Use oaepLabel instead, which
    is the name of the documented option.
    
    PR-URL: #44455
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    35cbe1a View commit details
    Browse the repository at this point in the history
  4. src: remove base64_select_table and base64_table

    node::base64_encode() uses ::base64_encode() when the mode is
    Base64Mode::NORMAL, so base64_select_table is only ever called for
    Base64Mode::URL and thus only ever returns base64_table_url, but never
    base64_table.
    
    Also move base64_table_url into base64-inl.h.
    
    PR-URL: #44425
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fd611cc View commit details
    Browse the repository at this point in the history
  5. node-api: avoid calling virtual methods in base's dtor

    Derived classes' fields are already destroyed if the virtual methods are
    invoked in the base class's destructor. It is not safe to call virtual
    methods in base's dtor.
    
    PR-URL: #44424
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    legendecas authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ef08cbd View commit details
    Browse the repository at this point in the history
  6. test: split heap prof tests

    The original heap prof tests can take too long to complete on
    azure Windows machines, resulting in timeouts. Split them into
    smaller tests and move them into the parallel directory to
    speed up the execution.
    
    PR-URL: #44388
    Refs: nodejs/reliability#356
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    0f071b8 View commit details
    Browse the repository at this point in the history
  7. test: make the vm timeout escape tests more lenient

    Previously the tests required that Node.js finish the initialization
    of the watchdog thread and fires the timeout within 100ms, which
    can be difficult on certain systems under load. This patch
    relaxes the requirement to 2000ms. If there is a bug and the
    timeout can actually be escaped, raising the timeout to 2000ms
    would not make a difference anyway.
    
    PR-URL: #44433
    Refs: nodejs/reliability#333
    Refs: nodejs/reliability#361
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    joyeecheung authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    0af15c7 View commit details
    Browse the repository at this point in the history
  8. test: deflake child process exec timeout tests

    On Windows it might take too long for the parent to start the
    communication with a child process, so by the time the parent
    starts its own timer, the child process might have already
    completed running, and the parent in those tests won't have a
    chance to terminate these child processes after the timeout.
    To address this issue, raise the time for which the child is
    supposed to run to make sure that the parent starts
    its own timer before the child terminates in the tests.
    Also, split the test into smaller ones to reduce the overhead.
    
    PR-URL: #44390
    Refs: nodejs/reliability#356
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    joyeecheung authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e36ed44 View commit details
    Browse the repository at this point in the history
  9. src: add error handling to uv_uptime call

    PR-URL: #44386
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    juanarbol authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    dcc1cf4 View commit details
    Browse the repository at this point in the history
  10. deps: update Acorn to v8.8.0

    PR-URL: #44437
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    255e7fb View commit details
    Browse the repository at this point in the history
  11. doc: add missing imports in events sample code

    There were missing imports in the example for using
    `EventEmitterAsyncResource`, so I added them in both ESM and CJS.
    
    PR-URL: #44337
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    mrbrianevans authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    71c8696 View commit details
    Browse the repository at this point in the history
  12. doc: improve assert.snapshot() docs

    PR-URL: #44429
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    cjihrig authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ae028e8 View commit details
    Browse the repository at this point in the history
  13. test: style updates for assert.snapshot()

    This commit updates the assert.snapshot() fixtures to better
    match the code style of the rest of the codebase.
    
    PR-URL: #44429
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    cjihrig authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    0d77342 View commit details
    Browse the repository at this point in the history
  14. doc: add --update-assert-snapshot to node.1

    PR-URL: #44429
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    cjihrig authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    11452a9 View commit details
    Browse the repository at this point in the history
  15. src: simplify enable_if logic of ToStringHelper::BaseConvert

    PR-URL: #44306
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    F3n67u authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c5413a1 View commit details
    Browse the repository at this point in the history
  16. test: avoid race in file write stream handle tests

    The test previously created two fs.promises.open calls on the
    same file with w+ back-to-back, and one of them could fail
    when checking the contents of that file if the other happened
    to be opening the file for write. Split them into different
    tests (with different tmpdir) to avoid the race.
    
    PR-URL: #44380
    Refs: nodejs/reliability#354
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    joyeecheung authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4c33e5d View commit details
    Browse the repository at this point in the history
  17. deps: V8: backport ff8d67c88449

    Original commit message:
    
        Reland "Fix Context PromiseHook behaviour with debugger enabled"
    
        This is a reland of commit 872b7faa32d837f9b166d750328357f856168e72
    
        Original change's description:
        > Fix Context PromiseHook behaviour with debugger enabled
        >
        > This is a solution for #43148.
        >
        > Due to differences in behaviour between code with and without the debugger enabled, some promise lifecycle events were being missed and some extra ones were being added. This change resolves this and verifies the event sequence is consistent between code with and without the debugger.
        >
        > Change-Id: I3dabf1dceb14233226b1752083d659f1c2f97966
        > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779922
        > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
        > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        > Cr-Commit-Position: refs/heads/main@{#82132}
    
        Change-Id: Ifdd407261c793887fbd012d5a04ba36b3744c349
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805979
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Reviewed-by: Clemens Backes <clemensb@chromium.org>
        Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        Reviewed-by: Victor Gomes <victorgomes@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#82575}
    
    Refs: v8/v8@ff8d67c
    Fixes: #43148
    Fixes: #44415
    PR-URL: #44423
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    targos authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c5630ad View commit details
    Browse the repository at this point in the history
  18. src: expose environment RequestInterrupt api

    Allow add-ons to interrupt JavaScript execution, and wake up loop if it
    is currently idle.
    
    PR-URL: #44362
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    legendecas authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4331bbe View commit details
    Browse the repository at this point in the history
  19. src: avoid casting std::trunc(... / ...) to size_t

    Given that the divisor is not zero, the result of dividing unsigned
    integers is an unsigned integer that is always rounded down, i.e.,
    there is no need to call std::trunc(). Doing so unnecessarily yields
    a floating-point number, requiring the result to be cast to an unsigned
    integer again.
    
    PR-URL: #44467
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    18b7208 View commit details
    Browse the repository at this point in the history
  20. src: fix incorrect comments in crypto

    PR-URL: #44470
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    aa34f73 View commit details
    Browse the repository at this point in the history
  21. src: improve error handling in CloneSSLCerts

    If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead
    of silently ignoring the error.
    
    PR-URL: #44410
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    125ab7d View commit details
    Browse the repository at this point in the history
  22. doc: use serial comma in addons docs

    Refs: #11321
    Refs: #17384
    PR-URL: #44482
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    54b6ed5 View commit details
    Browse the repository at this point in the history
  23. report: fix missing section javascriptHeap on OOMError

    `Environment::GetCurrent` may not available in the context of OOM.
    Removes the cyclic `Environment::GetCurrent` and `env->isolate()`
    calls to ensure both `isolate` and `env` is present if available.
    
    However, this behavior is not guaranteed. As
    `Environment::GetCurrent` didn't allocate new handles in the heap,
    when a Context is entered it can still get the valid env pointer.
    Removes the unstable assertion of the absence of env in the test.
    
    PR-URL: #44398
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    legendecas authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b17cc87 View commit details
    Browse the repository at this point in the history
  24. report: get stack trace with cross origin contexts

    When a new context with a different security token is entered, or
    when no context is entered, `StackTrace::CurrentStackTrace` need to
    be explicitly set with flag `kExposeFramesAcrossSecurityOrigins` to
    avoid crashing.
    
    PR-URL: #44398
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    legendecas authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    807b1e5 View commit details
    Browse the repository at this point in the history
  25. deps: upgrade npm to 8.19.1

    PR-URL: #44486
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    npm-cli-bot authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    cf19a79 View commit details
    Browse the repository at this point in the history
  26. doc: do not use "Returns:" for crypto.constants

    This is not a function and should not use the term "return" to describe
    its type or value.
    
    PR-URL: #44481
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    05006ed View commit details
    Browse the repository at this point in the history
  27. crypto: add digest name to INVALID_DIGEST errors

    We already do this in some places. This adds the digest name to
    remaining uses of ERR_CRYPTO_INVALID_DIGEST except for one occurrence in
    crypto_sig.cc that would require significant refactoring due to the
    unusual error handling there.
    
    PR-URL: #44468
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c868e36 View commit details
    Browse the repository at this point in the history
  28. crypto: handle invalid prepareAsymmetricKey JWK inputs

    Fixes #44471
    
    PR-URL: #44475
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    panva authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5cefd02 View commit details
    Browse the repository at this point in the history
  29. stream: fix setting abort reason in ReadableStream.pipeTo()

    In 14.2 in the specification, `error` should be signal’s abort reason.
    The current behavior seems to assume that only an `AbortError` instance
    is given as signal’s abort reason.
    
    Refs: https://streams.spec.whatwg.org/#readable-stream-pipe-to
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44418
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    daeyeon authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2facf8b View commit details
    Browse the repository at this point in the history
  30. test_runner: fix duration_ms to be milliseconds

    PR-URL: #44450
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    MoLow authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a35c2f9 View commit details
    Browse the repository at this point in the history
  31. meta: update AUTHORS

    PR-URL: #44511
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    nodejs-github-bot authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e519ac7 View commit details
    Browse the repository at this point in the history
  32. tools: update lint-md-dependencies to rollup@2.79.0

    PR-URL: #44510
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    nodejs-github-bot authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6fe189b View commit details
    Browse the repository at this point in the history
  33. src: rename misleading arg in ClientHelloParser

    Despite being named onend_arg, the pointer is passed both to the
    onend_cb and to the onhello_cb. Rename it to cb_arg, which matches the
    name of the class field cb_arg_.
    
    PR-URL: #44500
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fc17b80 View commit details
    Browse the repository at this point in the history
  34. doc: add missing parenthesis in TLSSocket section

    PR-URL: #44512
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1c87a7e View commit details
    Browse the repository at this point in the history
  35. deps: update corepack to 0.14.0

    PR-URL: #44509
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8ef5c40 View commit details
    Browse the repository at this point in the history
  36. 2022-09-08, Version v18.9.0 (Current)

    Notable changes:
    
    * doc:
      * add daeyeon to collaborators (Daeyeon Jeong) #44355
    * lib:
      * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) #44045
    * os:
      * (SEMVER-MINOR) add machine method (theanarkh) #44416
    * report:
      * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) #44255
    * src:
      * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) #44362
    * vm:
      * include vm context in the embedded snapshot (Joyee Cheung) #44252
    
    PR-URL: #44521
    RafaelGSS committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    9ae2af4 View commit details
    Browse the repository at this point in the history