-
-
Notifications
You must be signed in to change notification settings - Fork 32k
test_runner: add --test-name-pattern CLI flag #44508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
// Flags: --no-warnings --test-name-pattern=enabled --test-name-pattern=/pattern/i | ||
'use strict'; | ||
const common = require('../common'); | ||
const { | ||
after, | ||
afterEach, | ||
before, | ||
beforeEach, | ||
describe, | ||
it, | ||
test, | ||
} = require('node:test'); | ||
|
||
test('top level test disabled', common.mustNotCall()); | ||
test('top level skipped test disabled', { skip: true }, common.mustNotCall()); | ||
test('top level skipped test enabled', { skip: true }, common.mustNotCall()); | ||
it('top level it enabled', common.mustCall()); | ||
it('top level it disabled', common.mustNotCall()); | ||
it.skip('top level skipped it disabled', common.mustNotCall()); | ||
it.skip('top level skipped it enabled', common.mustNotCall()); | ||
describe('top level describe disabled', common.mustNotCall()); | ||
describe.skip('top level skipped describe disabled', common.mustNotCall()); | ||
describe.skip('top level skipped describe enabled', common.mustNotCall()); | ||
test('top level runs because name includes PaTtErN', common.mustCall()); | ||
|
||
test('top level test enabled', common.mustCall(async (t) => { | ||
t.beforeEach(common.mustCall()); | ||
t.afterEach(common.mustCall()); | ||
await t.test( | ||
'nested test runs because name includes PATTERN', | ||
common.mustCall() | ||
); | ||
})); | ||
|
||
describe('top level describe enabled', () => { | ||
before(common.mustCall()); | ||
beforeEach(common.mustCall(2)); | ||
afterEach(common.mustCall(2)); | ||
after(common.mustCall()); | ||
|
||
it('nested it disabled', common.mustNotCall()); | ||
it('nested it enabled', common.mustCall()); | ||
describe('nested describe disabled', common.mustNotCall()); | ||
describe('nested describe enabled', common.mustCall(() => { | ||
it('is enabled', common.mustCall()); | ||
})); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
TAP version 13 | ||
# Subtest: top level test disabled | ||
ok 1 - top level test disabled # SKIP test name does not match pattern | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level skipped test disabled | ||
ok 2 - top level skipped test disabled # SKIP test name does not match pattern | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level skipped test enabled | ||
ok 3 - top level skipped test enabled # SKIP | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level it enabled | ||
ok 4 - top level it enabled | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level it disabled | ||
ok 5 - top level it disabled # SKIP test name does not match pattern | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level skipped it disabled | ||
ok 6 - top level skipped it disabled # SKIP test name does not match pattern | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level skipped it enabled | ||
ok 7 - top level skipped it enabled # SKIP | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level describe disabled | ||
ok 8 - top level describe disabled # SKIP test name does not match pattern | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level skipped describe disabled | ||
ok 9 - top level skipped describe disabled # SKIP test name does not match pattern | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level skipped describe enabled | ||
ok 10 - top level skipped describe enabled # SKIP | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level runs because name includes PaTtErN | ||
ok 11 - top level runs because name includes PaTtErN | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level test enabled | ||
# Subtest: nested test runs because name includes PATTERN | ||
ok 1 - nested test runs because name includes PATTERN | ||
--- | ||
duration_ms: * | ||
... | ||
1..1 | ||
ok 12 - top level test enabled | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: top level describe enabled | ||
# Subtest: nested it disabled | ||
ok 1 - nested it disabled # SKIP test name does not match pattern | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: nested it enabled | ||
ok 2 - nested it enabled | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: nested describe disabled | ||
ok 3 - nested describe disabled # SKIP test name does not match pattern | ||
--- | ||
duration_ms: * | ||
... | ||
# Subtest: nested describe enabled | ||
# Subtest: is enabled | ||
ok 1 - is enabled | ||
--- | ||
duration_ms: * | ||
... | ||
1..1 | ||
ok 4 - nested describe enabled | ||
--- | ||
duration_ms: * | ||
... | ||
1..4 | ||
ok 13 - top level describe enabled | ||
--- | ||
duration_ms: * | ||
... | ||
1..13 | ||
# tests 13 | ||
# pass 4 | ||
# fail 0 | ||
# cancelled 0 | ||
# skipped 9 | ||
# todo 0 | ||
# duration_ms * |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.