perf_hooks: resource timing idlharness #44460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
legendecas
force-pushed
the
resource-timing-idlharness
branch
from
04099b8 to
5aa4d1a
Compare
aduh95
reviewed
Aug 30, 2022
| async function main() { | ||
| const invalidValues = [ null, undefined, true, false, -1, 1.1, Infinity, NaN, '', 'foo', {}, [], () => {} ]; | ||
| for (const value of invalidValues) { | ||
| assert.throws(() => performance.setResourceTimingBufferSize(value), `${value} should throw`); |
Contributor
There was a problem hiding this comment.
What should it throw?
Suggested change
| assert.throws(() => performance.setResourceTimingBufferSize(value), `${value} should throw`); | |
| assert.throws(() => performance.setResourceTimingBufferSize(value), { code:`ERR_INVALID_ARG_TYPE` }); |
aduh95
added
the
semver-major
aduh95
reviewed
Aug 30, 2022
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Semver-major as it adds a new global. It should be documented in globals.md, and an entry should be added in lib/eslintrc.yml as well.
Member
Author
|
Not all of the changes should be semver-major. I'll split this PR into smaller ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PerformanceEntryandPerformanceResourceTimingto theglobalThis.defineEventHandlershould check ifthisis a validEventTarget, as enforced by the idlharness.PerformanceResourceTimingto inherit the public interfacePerformanceEntryinstead of the internalInternalPerformanceResourceTiming.The first commit comes from #44439.