test: refactor test-net-connect-options-ipv6 #4395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused variable and refactor checking for event firing.
|
LGTM |
|
Nice. LGTM |
|
CI: https://ci.nodejs.org/job/node-test-commit/1524/ @cjihrig @mscdex I just pushed a trivial correction to the code. Just to keep things official and on-the-level, can you confirm that the change does not alter your |
|
LGTM |
|
Only CI failure is a known flaky and unrelated test. |
Trott
added a commit
that referenced
this pull request
Dec 25, 2015
Remove unused variable and refactor checking for event firing. PR-URL: #4395 Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in 7d1d0b7 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Remove unused variable and refactor checking for event firing. PR-URL: nodejs#4395 Reviewed-By: Brian White <mscdex@mscdex.net>
Trott
added a commit
that referenced
this pull request
Jan 7, 2016
Remove unused variable and refactor checking for event firing. PR-URL: #4395 Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Remove unused variable and refactor checking for event firing. PR-URL: #4395 Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Remove unused variable and refactor checking for event firing. PR-URL: nodejs#4395 Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused variable and refactor checking for event firing.