stream: fix Transform with hwm 0 regression #43648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Fixes: nodejs#40935 Refs: nodejs#40947 Refs: nodejs#42457
kanongil
force-pushed
the
fix-transform-hwm0
branch
from
6c98049
to
b8a1698
Compare
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
|
Looking at this now. I agree the hwm === 0 check is incorrect. Not sure about the fix though. Digging into it. |
github-actions
bot
removed
the
request-ci
|
@kanongil Could you rename this PR or create a new one for lazy reading? |
aduh95
removed
the
author ready
|
Removing |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes a patch from #40947, and reworks it to continue handling backpressure when
highWaterMark: 0, as described in #42457 (comment).The new test fails on node releases with the patch from #40947, like v16.4, and passes on node v14 and node v16.3 from before it was introduced. It is also designed, so that it will fail if
highWaterMark: 1is set instead.