deps: update OpenSSL 3.0.4+quic #43603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates all sources in deps/openssl/openssl by:
$ git clone git@github.com:quictls/openssl.git
$ cd openssl
$ git checkout openssl-3.0.4+quic
$ cd ../node/deps/openssl
$ rm -rf openssl
$ cp -R ../../../openssl openssl
$ rm -rf openssl/.git* openssl/.travis*
$ git add --all openssl
$ git commit openssl
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config clean-s
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl
$ git commit
|
Review requested:
|
nodejs-github-bot
added
dependencies
|
I think we should wait for 3.0.5 instead as there was a vulnerability introduced in 3.0.4. |
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Jun 29, 2022
|
32-bit Windows is failing to compile 😞. |
|
The Win32 error is probably openssl/openssl#18459 😞 |
You right. Also, likely we'll need to update our openssl/config/Makefile to support |
This was referenced Jun 30, 2022
|
@RafaelGSS we'll need to regenerate the OpenSSL config after 3b4fa48 for it to have any effect. |
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl
$ git commit
|
Closing in favor of: #43693 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated openssl dep to openssl-3.0.4p+quic using the maintenance guide.
Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-June/000228.html
In this PR I had to run to clean up all
.sfilesNote: if that's works, I'll update the maintaining-openssl document