Skip to content

test: mark test-http-server-request-timeouts-mixed flaky on macOS#43597

Closed
F3n67u wants to merge 1 commit intonodejs:mainfrom
F3n67u:flaky-test-http-server-request-timeouts-mixed
Closed

test: mark test-http-server-request-timeouts-mixed flaky on macOS#43597
F3n67u wants to merge 1 commit intonodejs:mainfrom
F3n67u:flaky-test-http-server-request-timeouts-mixed

Conversation

@F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Jun 28, 2022 •
edited
Loading

This test is the top 1 flaky test all last week. I think we would better mark it as flaky temporally.

After #43470 merged, we could remove this flaky mark.

Refs:

cc @ShogunPanda @MrJithil

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 28, 2022
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@F3n67u F3n67u mentioned this pull request Jun 28, 2022
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44922/

@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44927/

@ShogunPanda
Copy link
Contributor

ShogunPanda commented Jun 28, 2022

Thanks @F3n67u!
It was on my TODO list but I was overwhelmed.
Shall we fast-track this to make people's life better?

@F3n67u
Copy link
Contributor Author

F3n67u commented Jun 28, 2022 •
edited
Loading

Thanks @F3n67u!
It was on my TODO list but I was overwhelmed.
Shall we fast-track this to make people's life better?

Yes! I am not a collaborator. Could you add the fast-track label, please?

@ShogunPanda ShogunPanda added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2022

Fast-track has been requested by @ShogunPanda. Please 👍 to approve.

@LiviaMedeiros LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 28, 2022
ShogunPanda pushed a commit that referenced this pull request Jun 28, 2022
@F3n67u @ShogunPanda
test: mark test-http-server-request-timeouts-mixed flaky on macOS
bc5f9e1 
PR-URL: #43597
Refs: #43465
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@ShogunPanda
Copy link
Contributor

ShogunPanda commented Jun 28, 2022

Landed in bc5f9e1

@LiviaMedeiros LiviaMedeiros removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 28, 2022
@F3n67u F3n67u deleted the flaky-test-http-server-request-timeouts-mixed branch June 28, 2022 11:07
@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Open
23 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
test: mark test-http-server-request-timeouts-mixed flaky on macOS
7c6f548 
PR-URL: #43597
Refs: #43465
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
test: mark test-http-server-request-timeouts-mixed flaky on macOS
a3a2a9e 
PR-URL: #43597
Refs: #43465
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
test: mark test-http-server-request-timeouts-mixed flaky on macOS
23ac14a 
PR-URL: nodejs/node#43597
Refs: nodejs/node#43465
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@F3n67u @nodejs-github-bot @ShogunPanda @LiviaMedeiros