Closed
Conversation
This updates all sources in deps/openssl/openssl by:
$ git clone git@github.com:quictls/openssl.git
$ cd openssl
$ git checkout openssl-3.0.4+quic
$ cd ../node/deps/openssl
$ rm -rf openssl
$ cp -R ../../../openssl openssl
$ rm -rf openssl/.git* openssl/.travis*
$ git add --all openssl
$ git commit openssl
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl
$ git commit
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
aduh95
changed the title
richardlau
changed the title
github-actions
bot
removed
the
request-ci
Collaborator
richardlau
approved these changes
Jun 22, 2022
richardlau
added
the
commit-queue-rebase
tniessen
approved these changes
Jun 22, 2022
Member
|
The diff size always bothers me. Hundreds of thousands of lines... |
33 tasks
Collaborator
Collaborator
Member
Author
|
@richardlau it keeps failing, and I haven't found any insights in the logs. Do you have any idea? |
Collaborator
Member
Hmm I've not seen this before -- the PR rebasing onto the base branch (main) somehow isn't working 😞. I'm not sure why. |
This was referenced Jun 24, 2022
Member
Author
|
Recreating from scratch. |
Member
Author
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated openssl dep to openssl-3.0.4p+quic using the maintenance guide.
Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-June/000228.html