Skip to content

crypto: fix webcrypto import of cfrg raw public keys#43404

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
panva:fix-cfrg-import-raw
Jun 15, 2022
Merged

crypto: fix webcrypto import of cfrg raw public keys#43404
nodejs-github-bot merged 1 commit intonodejs:masterfrom
panva:fix-cfrg-import-raw

Conversation

@panva
Copy link
Member

@panva panva commented Jun 13, 2022 •
edited
Loading

Fixes import of raw CFRG public keys in Web Crypto API.

Before:

const x = Buffer.from(crypto.generateKeyPairSync('ed25519').publicKey.export({ format: 'jwk' }).x, 'base64')
await crypto.subtle.importKey('raw', x, 'Ed25519', true, ['verify'])
DOMException [OperationError]: Unable to import CFRG key
    at new DOMException (node:internal/per_context/domexception:53:5)
    at __node_internal_ (node:internal/util:502:10)
    at Object.cfrgImportKey (node:internal/crypto/cfrg:300:15)
    at SubtleCrypto.importKey (node:internal/crypto/webcrypto:528:10)

After:

CryptoKey {
  type: 'public',
  extractable: true,
  algorithm: { name: 'Ed25519' },
  usages: [ 'verify' ]
}

@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto labels Jun 13, 2022
@panva panva requested review from jasnell and tniessen June 13, 2022 13:21
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 13, 2022

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 13, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 13, 2022
@panva
Copy link
Member Author

panva commented Jun 13, 2022

@twiss FYI

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 14, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44546/

@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Open
17 tasks
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5fad0b9 into nodejs:master Jun 15, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 15, 2022

Landed in 5fad0b9

@github-actions github-actions bot mentioned this pull request Jun 16, 2022
Open
22 tasks
danielleadams pushed a commit that referenced this pull request Jun 16, 2022
@panva @danielleadams
crypto: fix webcrypto import of cfrg raw public keys
9f1de2c 
PR-URL: #43404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Jun 16, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Open
31 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
@panva @targos
crypto: fix webcrypto import of cfrg raw public keys
d4d7f6d 
PR-URL: #43404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
@panva @targos
crypto: fix webcrypto import of cfrg raw public keys
97b2fef 
PR-URL: #43404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@panva @guangwong
crypto: fix webcrypto import of cfrg raw public keys
f1e0f92 
PR-URL: nodejs/node#43404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva panva deleted the fix-cfrg-import-raw branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva @nodejs-github-bot @jasnell @tniessen