Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick 3ebf2052a1b2 #43147

Closed
wants to merge 2 commits into from
Closed

deps: V8: cherry-pick 3ebf2052a1b2 #43147

wants to merge 2 commits into from

Conversation

LiuYu396
Copy link

Original commit message:

[mips64] Remove a useless declaration of Operand.

Change-Id: I5144d8315b5c1aca751d138e4d87240b703dc9e3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650359
Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Auto-Submit: Yu Liu <liuyu@loongson.cn>
Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#80585}

Refs: v8/v8@3ebf205

@LiuYu396
deps: V8: cherry-pick 3ebf2052a1b2
d8c48a2 
  Original commit message:

    [mips64] Remove a useless declaration of Operand.

    Change-Id: I5144d8315b5c1aca751d138e4d87240b703dc9e3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650359
    Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Auto-Submit: Yu Liu <liuyu@loongson.cn>
    Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Cr-Commit-Position: refs/heads/main@{#80585}

Refs: v8/v8@3ebf205
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v16.x v8 engine Issues and PRs related to the V8 dependency. labels May 19, 2022
@targos targos changed the base branch from v16.x to v16.x-staging May 19, 2022 13:07
richardlau
richardlau reviewed May 19, 2022
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should increase the v8_embedder_string number in common.gypi:
https://github.com/nodejs/node/blob/master/doc/contributing/maintaining-V8.md#backporting-to-abandoned-branches

@LiuYu396
Copy link
Author

Hello everyone, can you help to merge this pull request ?
I do not have permission to land it.

@LiuYu396
Copy link
Author

This should increase the v8_embedder_string number in common.gypi: https://github.com/nodejs/node/blob/master/doc/contributing/maintaining-V8.md#backporting-to-abandoned-branches

Done.

@LiuYu396
Copy link
Author

@targos @JungMinu @richardlau Hi,
Can you help to merge this pull request ?

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. labels May 25, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44158/

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels May 25, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
@LiuYu396 @juanarbol
deps: V8: cherry-pick 3ebf2052a1b2
1c8fa4d 
  Original commit message:

    [mips64] Remove a useless declaration of Operand.

    Change-Id: I5144d8315b5c1aca751d138e4d87240b703dc9e3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650359
    Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Auto-Submit: Yu Liu <liuyu@loongson.cn>
    Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Cr-Commit-Position: refs/heads/main@{#80585}

Refs: v8/v8@3ebf205
PR-URL: #43147
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
juanarbol pushed a commit that referenced this pull request Jun 1, 2022
@LiuYu396 @juanarbol
deps: V8: cherry-pick 3ebf2052a1b2
f7c4ce2 
  Original commit message:

    [mips64] Remove a useless declaration of Operand.

    Change-Id: I5144d8315b5c1aca751d138e4d87240b703dc9e3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650359
    Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Auto-Submit: Yu Liu <liuyu@loongson.cn>
    Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Cr-Commit-Position: refs/heads/main@{#80585}

Refs: v8/v8@3ebf205

PR-URL: #43147
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
juanarbol added a commit that referenced this pull request Jun 1, 2022
@juanarbol
2022-05-XX, Version 16.15.1 'Gallium' (LTS), @tdb
004415d 
Notable changes

OpenSSL:

* add --openssl-legacy-provider option (Daniel Bevenius) #40478

deps:

* V8: cherry-pick 3ebf2052a1b2 (Liu Yu) #43147
* upgrade npm to 8.11.0 (npm-cli+bot@github.com) #43210

Other notable changes:

* tools: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488
* tools: update V8 gypfiles for 9.6 (Michaël Zasso) #40488

PR-URL: TDB
@juanarbol juanarbol mentioned this pull request Jun 1, 2022
Merged
juanarbol added a commit that referenced this pull request Jun 1, 2022
@juanarbol
2022-05-XX, Version 16.15.1 'Gallium' (LTS), @tdb
67afa76 
Notable changes

OpenSSL:

* add --openssl-legacy-provider option (Daniel Bevenius) #40478

deps:

* V8: cherry-pick 3ebf2052a1b2 (Liu Yu) #43147
* upgrade npm to 8.11.0 (npm-cli+bot@github.com) #43210

Other notable changes:

* tools: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488
* tools: update V8 gypfiles for 9.6 (Michaël Zasso) #40488

PR-URL: #43272
juanarbol added a commit that referenced this pull request Jun 1, 2022
@juanarbol
2022-05-XX, Version 16.15.1 'Gallium' (LTS), @tdb
81fb221 
Notable changes

OpenSSL:

* add --openssl-legacy-provider option (Daniel Bevenius) #40478

deps:

* V8: cherry-pick 3ebf2052a1b2 (Liu Yu) #43147
* upgrade npm to 8.11.0 (npm-cli+bot@github.com) #43210

Other notable changes:

* tools: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488
* tools: update V8 gypfiles for 9.6 (Michaël Zasso) #40488

PR-URL: #43272
@juanarbol
Copy link
Member

This is really appreciated; and good news, your first PR goes to an LTS release :shipit:

Landed in f7c4ce2 🎉 💚

@juanarbol juanarbol closed this Jun 1, 2022
@LiuYu396
Copy link
Author

LiuYu396 commented Jun 2, 2022

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@JungMinu JungMinu JungMinu approved these changes

@targos targos targos approved these changes

@richardlau richardlau Awaiting requested review from richardlau

Assignees
No one assigned
Labels
commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LiuYu396 @nodejs-github-bot @juanarbol @targos @JungMinu @richardlau @BethGriggs