Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix debug-port-cluster flakiness #4310

Merged
merged 1 commit into from
Dec 16, 2015
Merged

test: fix debug-port-cluster flakiness #4310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 13 additions & 35 deletions test/parallel/test-debug-port-cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,47 +3,25 @@ var common = require('../common');
var assert = require('assert');
var spawn = require('child_process').spawn;

var port = common.PORT + 1337;
const PORT_MIN = common.PORT + 1337;
const PORT_MAX = PORT_MIN + 2;

var args = [
'--debug=' + port,
'--debug=' + PORT_MIN,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor nit... since we're starting to use template strings more frequently... perhaps:

`--debug=${PORT_MIN}`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that in my first (unpushed) revision but then I thought "meh, change for the sake of it and incongruous with the line below" so I left it out.

common.fixturesDir + '/clustered-server/app.js'
];

var child = spawn(process.execPath, args);
var outputLines = [];
const child = spawn(process.execPath, args);
child.stderr.setEncoding('utf8');

child.stderr.on('data', function(data) {
var lines = data.toString().replace(/\r/g, '').trim().split('\n');
var line = lines[0];

lines.forEach(function(ln) { console.log('> ' + ln); } );

if (line === 'all workers are running') {
assertOutputLines();
process.exit();
} else {
outputLines = outputLines.concat(lines);
}
});

process.on('exit', function onExit() {
child.kill();
let stderr = '';
child.stderr.on('data', data => {
stderr += data;
if (child.killed !== true && stderr.includes('all workers are running'))
child.kill();
});

var assertOutputLines = common.mustCall(function() {
var expectedLines = [
'Debugger listening on port ' + port,
'Debugger listening on port ' + (port + 1),
'Debugger listening on port ' + (port + 2),
];

// Do not assume any particular order of output messages,
// since workers can take different amout of time to
// start up
outputLines.sort();

assert.equal(outputLines.length, expectedLines.length);
for (var i = 0; i < expectedLines.length; i++)
assert.equal(outputLines[i], expectedLines[i]);
process.on('exit', () => {
for (let port = PORT_MIN; port <= PORT_MAX; port += 1)
assert(stderr.includes(`Debugger listening on port ${port}`));
});