Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update .mailmap for recent README name change #43027

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented May 9, 2022

No description provided.

@Trott Trott requested a review from himself65 May 9, 2022 21:00
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 9, 2022
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed meta Issues and PRs related to the general management of the project. labels May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@@ -3460,5 +3460,6 @@ liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>
Sergey Nazaryev <sergey@nazaryev.com>
William Marlow <william.marlow@ibm.com>
Keyhan Vakil <60900335+airtable-keyhanvakil@users.noreply.github.com>
Feng Yu <F3n67u@outlook.com>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a side-effect of running tools/update-authors.js after updating .mailmap. I think it's fine to leave it, rather than removing it only so that the scheduled job re-adds it in a few days.

@Trott
Copy link
Member Author

Trott commented May 9, 2022

Without this change, it's possible that tools/find-inactive-collaborators.js will incorrectly flag the user as inactive.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
@Trott Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
@Trott
Copy link
Member Author

Trott commented May 9, 2022

Removed commit-queue label because this needs one more fast-track approval. Feel free to add it back if/when this gets that second approval.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43027
✔  Done loading data for nodejs/node/pull/43027
----------------------------------- PR info ------------------------------------
Title      meta: update .mailmap for recent README name change (#43027)
Author     Rich Trott  (@Trott)
Branch     Trott:update -> nodejs:master
Labels     fast-track, author ready
Commits    1
 - meta: update .mailmap for recent README name change
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/43027
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43027
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 09 May 2022 21:00:27 GMT
   ✔  Approvals: 3
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/43027#pullrequestreview-966828530
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43027#pullrequestreview-966884084
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43027#pullrequestreview-967180646
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2298687477

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 10, 2022
@himself65 himself65 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 10, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43027
✔  Done loading data for nodejs/node/pull/43027
----------------------------------- PR info ------------------------------------
Title      meta: update .mailmap for recent README name change (#43027)
Author     Rich Trott  (@Trott)
Branch     Trott:update -> nodejs:master
Labels     fast-track, author ready
Commits    1
 - meta: update .mailmap for recent README name change
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/43027
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43027
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 09 May 2022 21:00:27 GMT
   ✔  Approvals: 3
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/43027#pullrequestreview-966828530
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43027#pullrequestreview-966884084
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43027#pullrequestreview-967180646
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2301687056

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. labels May 10, 2022
PR-URL: nodejs#43027
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented May 10, 2022

Landed in 761b87a

@Trott Trott merged commit 761b87a into nodejs:master May 10, 2022
@Trott Trott deleted the update branch May 10, 2022 22:48
BethGriggs pushed a commit that referenced this pull request May 16, 2022
PR-URL: #43027
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 16, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43027
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #43027
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43027
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43027
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43027
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants