Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: fix socket._getpeername #43010

Merged
merged 3 commits into from
Jul 25, 2022
Merged

net: fix socket._getpeername #43010

merged 3 commits into from
Jul 25, 2022

Commits on May 23, 2022

  1. net: fix socket._getpeername 

    Fixes: nodejs#43009

If calling `this._handle.getpeername` returns an error at the first
call, its result shouldn't be cached to `this._peername`.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed May 23, 2022
    Configuration menu
    Copy the full SHA
    fd20648 View commit details
    Browse the repository at this point in the history

  2. fix: returning out 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed May 23, 2022
    Configuration menu
    Copy the full SHA
    df47a46 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. fixup: remove todo on _getpeername 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed May 24, 2022
    Configuration menu
    Copy the full SHA
    0fe4a49 View commit details
    Browse the repository at this point in the history