Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix indeterminacy of icu_locales value #42865

Merged
merged 1 commit into from
May 6, 2022

Commits on Apr 25, 2022

  1. build: fix indeterminacy of icu_locales value

    `icu_locales` is generated by joining values from `set` data structure.
    However, `set` doesn't guarantee an order, so the result of
    `icu_locales` is not determined. For example, the result value could be
    'en,root' or 'root,en'. This fix makes it deterministic.
    
    The main reason of this fix is to restore the reproducibility of the
    build because the value of `icu_locales` is embedded into `node` binary.
    3ap committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    bd69f29 View commit details
    Browse the repository at this point in the history